[Bug 732898] New: Firefox is not accessible
https://bugzilla.novell.com/show_bug.cgi?id=732898 https://bugzilla.novell.com/show_bug.cgi?id=732898#c0 Summary: Firefox is not accessible Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: All OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Firefox AssignedTo: bnc-team-mozilla@forge.provo.novell.com ReportedBy: mgorse@suse.com QAContact: qa@suse.de Found By: --- Blocker: --- Firefox is inaccessible under OpenSUSE 12.1 unless one sets the old gconf accessibility key or sets GNOME_ACCESSIBILITY=1 in the environment. This is a general problem that should be fixed upstream; I've filed http://bugzilla.mozilla.org/show_bug.cgi?id=693343. The bug is still open at present, although I believe my latest patch there has addressed the comments from various reviewers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c1
Michael Gorse
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c2
--- Comment #2 from Wolfgang Rosenauer
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c3
--- Comment #3 from Wolfgang Rosenauer
diff -ur mozilla.orig/accessible/src/atk/nsApplicationAccessibleWrap.cpp mozilla/accessible/src/atk/nsApplicationAccessibleWrap.cpp --- mozilla.orig/accessible/src/atk/nsApplicationAccessibleWrap.cpp 2011-11-06 02:34:00.000000000 -0600 +++ mozilla/accessible/src/atk/nsApplicationAccessibleWrap.cpp 2011-11-26 20:32:59.939341632 -0600 @@ -52,19 +52,17 @@
#include
#include +#include
Including without checking if dbus is enabled/available? That might work in our build configuration but usually I'd like to have patches which could be applied and do the right thing for everyone.
-static bool sATKChecked = false; +static PRBool sATKChecked = PR_FALSE;
Why that? Starting with Firefox 10 PRBool is not used in the mozilla tree (minus nspr/nss) anymore intentionally.
+void +PreInit() +{ + static PRBool sChecked = FALSE;
PRBool again as in following places. Thanks for the work! I'm going to add the patch to the beta builds of Firefox 9 and Thunderbird 9 for now. Those are to be released December, 20th Or do you think we should release an official update based on FF8 and TB8 earlier? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c4
Wolfgang Rosenauer
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c5
--- Comment #5 from Michael Gorse
+#include
Including without checking if dbus is enabled/available? That might work in our build configuration but usually I'd like to have patches which could be applied and do the right thing for everyone.
Right. Thanks for the catch. I've updated the patch on the upstream bug and added the check in a couple places where it was missing.
-static bool sATKChecked = false; +static PRBool sATKChecked = PR_FALSE;
Why that? Starting with Firefox 10 PRBool is not used in the mozilla tree (minus nspr/nss) anymore intentionally.
Looks like I was a bit hasty/over-zealous there; I was trying to make sure it would build, since I was backporting to Firefox 8, but that change at least wasn't needed.
I'm going to add the patch to the beta builds of Firefox 9 and Thunderbird 9 for now. Those are to be released December, 20th Or do you think we should release an official update based on FF8 and TB8 earlier?
Hmm; good question. If we have any other reason for pushing an update, then I think it would be good for it to be included, at least. Btw, is there a good way to test the beta package on 12.1 without installing factory / factory packages? Even the "12.1" package in that repository wants mozilla-nss 3.13, where 12.1 has 3.12, and the repository doesn't seem to include a mozilla-nss package. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c6
--- Comment #6 from Wolfgang Rosenauer
Hmm; good question. If we have any other reason for pushing an update, then I think it would be good for it to be included, at least.
Agreed. Currently I see no need to update earlier though.
Btw, is there a good way to test the beta package on 12.1 without installing factory / factory packages? Even the "12.1" package in that repository wants mozilla-nss 3.13, where 12.1 has 3.12, and the repository doesn't seem to include a mozilla-nss package.
mozilla:beta builds/depends on mozilla which contains nss 3.13.1. nss 3.13.1 will be delivered to 12.1 anyway with the update to Firefox 9 as it's a prerequirement. So it's even good for testing if you get it earlier ;-) So the way to get mozilla beta packages is to use both repos (mozilla, mozilla:beta) usually. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c7
--- Comment #7 from Michael Gorse
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c8
Wolfgang Rosenauer
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c9
--- Comment #9 from Bernhard Wiedemann
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c
Ludwig Nussel
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c10
Wolfgang Rosenauer
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c11
--- Comment #11 from Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=732898
https://bugzilla.novell.com/show_bug.cgi?id=732898#c12
--- Comment #12 from Swamp Workflow Management
http://bugzilla.novell.com/show_bug.cgi?id=732898
Swamp Workflow Management
http://bugzilla.novell.com/show_bug.cgi?id=732898
Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com