https://bugzilla.novell.com/show_bug.cgi?id=379515
User hoodedone@gmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=379515#c10
Raymond Planthold changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |REOPENED
Info Provider|hoodedone@gmail.com |
--- Comment #10 from Raymond Planthold 2008-04-17 04:51:01 MST ---
The patch at the moment is just copy/pasted from the Clearlooks style. It's
not "complete" in the sense that I want to make it attempt to simulate the full
range of KDE icon effects, which is why haven't submitted it to be included in
QtCurve proper. I've been too busy to muddle through that, however, so I'd say
it's safe to use as-is in the meantime. (Maybe with better commenting though.
I totally forgot I had put "copypasta" in my original edits to the source file
to mark off what I had changed. Heh.)
As for what the patch actually does: it appears that where KDE handles the
drawing of different icon states globally, GTK leaves that to the theme engine.
Since QtCurve didn't override the relevant functions, it got stuck with the
hideous default effect for disabled icons.
Anyway, big oops on the lack of .changes and other documentation. I'm still
mostly experimenting with the build service, so I'm not as diligent as I ought
to be on that.
On another note, thanks to Mark for pointing out the KDE3 config dialog error.
I was overzealous in pruning files from the spec file last time I edited and
didn't notice because KDE4 doesn't need a .la file.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.