https://bugzilla.novell.com/show_bug.cgi?id=400434 User maw@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=400434#c4 Michael Wolf <maw@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maw@novell.com --- Comment #4 from Michael Wolf <maw@novell.com> 2008-08-06 15:46:09 MDT --- (In reply to comment #3 from Peter Poeml)
I'm not sure if it should be impossible to commit changes that don't pass some checks. It should be possible to submit anything IMO. Such a check should be done before submission to opensuse factory maybe.
A problem is that checks which require parsing of the spec file often need some strange tools installed (the same as in BuildRequires). If they are not installed on the local machine, the check fails. (Just as it is the case with the Autobuild tools.)
But a possibility for such a check needs to exist anyway. At the very least, to notice stuff earlier, and not only when a change is submitted into factory (then it's too late).
I think it would be reasonable to look for files that a user would likely want to be to be versioned, such as anything ending in .spec, .changes, .gz, .bz2, patch, and .diff (or equivalent results from "file <file>", or both). Then, if any such files are found but not versioned, say which they are and ask the user whether he wants to go ahead and commit anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.