[Bug 400434] New: osc: Sanity checks before submit needed
https://bugzilla.novell.com/show_bug.cgi?id=400434 Summary: osc: Sanity checks before submit needed Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService AssignedTo: poeml@novell.com ReportedBy: crrodriguez@novell.com QAContact: adrian@novell.com CC: suse-tux@gmx.de Found By: --- Suppose I have this statement in foo.spec Source: foobar.txt but foobar.txt was not added with osc add nor was already present, the result is almost always a build faliure, wasted time and OBS resources. osc ci should do something like the checks present in autobuild **before** submit. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=400434
User suse-tux@gmx.de added comment
https://bugzilla.novell.com/show_bug.cgi?id=400434#c1
--- Comment #1 from Marcus Hüwe
Suppose I have this statement in foo.spec
Source: foobar.txt
but foobar.txt was not added with osc add nor was already present, the result is almost always a build faliure, wasted time and OBS resources.
Hmm maybe the backend should (also) do such a check before it sets up the build environment.
osc ci should do something like the checks present in autobuild **before** submit.
I just hacked something together but I'm not quite sure if osc is the right place for such a check. Additionally I'm not sure if we should make this feature mandatory (atm you have to explicitly set "abuild_mode" in your ~/.oscrc). Peter: what do you think? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=400434
User suse-tux@gmx.de added comment
https://bugzilla.novell.com/show_bug.cgi?id=400434#c2
--- Comment #2 from Marcus Hüwe
https://bugzilla.novell.com/show_bug.cgi?id=400434
User poeml@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=400434#c3
--- Comment #3 from Peter Poeml
https://bugzilla.novell.com/show_bug.cgi?id=400434
User maw@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=400434#c4
Michael Wolf
I'm not sure if it should be impossible to commit changes that don't pass some checks. It should be possible to submit anything IMO. Such a check should be done before submission to opensuse factory maybe.
A problem is that checks which require parsing of the spec file often need some strange tools installed (the same as in BuildRequires). If they are not installed on the local machine, the check fails. (Just as it is the case with the Autobuild tools.)
But a possibility for such a check needs to exist anyway. At the very least, to notice stuff earlier, and not only when a change is submitted into factory (then it's too late).
I think it would be reasonable to look for files that a user would likely want to be to be versioned, such as anything ending in .spec, .changes, .gz, .bz2, patch, and .diff (or equivalent results from "file <file>", or both). Then, if any such files are found but not versioned, say which they are and ask the user whether he wants to go ahead and commit anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=400434
Peter Poeml
https://bugzilla.novell.com/show_bug.cgi?id=400434
Peter Poeml
participants (1)
-
bugzilla_noreply@novell.com