https://bugzilla.novell.com/show_bug.cgi?id=354113
User bk@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=354113#c22
Bernhard Kaindl changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #194532|0 |1
is obsolete| |
Attachment #194750|0 |1
is obsolete| |
Status|NEEDINFO |NEW
Info Provider|bk@novell.com |
--- Comment #22 from Bernhard Kaindl 2008-02-18 12:43:22 MST ---
Created an attachment (id=195524)
--> (https://bugzilla.novell.com/attachment.cgi?id=195524)
attrib.i, generated with -m32
Indeed, I was on 64-bit and forgot to add -m32, and the shift warnings do
not occur on a normal i586 compile.
Here is the new attrib.i, generated with -m32:
gcc -m32 -DHAVE_CONFIG_H -I.. -I../include/ntfs-3g/ -E attrib.c >attrib.i
Compiling only attrib.c with -O0 is sufficient to work around the problem:
%ifarch %{ix86}
touch libntfs-3g/attrib.c
make CFLAGS="$CFLAGS -O0"
%endif
I added -W -Werror to the CFLAGS which I use, and fixed the resulting errors.
The only warning related to attrib.c was:
attrib.c:144: error: passing argument 1 of 'ntfs_log_redirect' discards
qualifiers from pointer target type
(at dozens of places)
That was caused by:
#define ntfs_log_critical(FORMAT, ARGS...)
ntfs_log_redirect(__FUNCTION__,__FILE__,__LINE__,NTFS_LOG_LEVEL_CRITICAL,NULL,FORMAT,##ARGS)
The passing argument 1 of 'ntfs_log_redirect' is defined as "const char *'.
I changed arg1 of the macro to: "(const char *)__FUNCTION__" and that fixed the
warning but attrib.c still seems broken or miscompiled.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.