https://bugzilla.novell.com/show_bug.cgi?id=374477
User pnemec@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=374477#c9
Pavel Nemec
thanks for the test framework. I had a look into the code and fixed some warnings as well as did some adaption according to the rest of the kiwi code style. I also divided the two packages KIWITest
I see you had a lot of work with it. We will try harder next time.
and KIWITestResult into two files. Beyond this I found the following
Well It is holder Object only...but this is more clear.
problems/inconsistencies which would be great if you can fix before we check it in:
1) you don't use the KIWILog module and functionality to print log messages: It would be great if you can add that. It works like the following:
my $kiwi = $self->{kiwi}; $kiwi -> info ("..."); $kiwi -> error ("...");
I already have added the initialization of the log module in the test framework
I do not get it here. I of course find out how to use your log facility, but we do not use print alone at all. Are you suggesting we should add some information prints to see status? My idea was that this should be done by calling part. see attachement #204389 Or our standalone application tester.pl http://svn.suse.de/viewvc/slepos/trunk/kiwi-test/tester/tester.pl?view=log In kiwi.pl I am using only kiwi-> info/note/errors call to print messages.
2) you use an xsd description to validate the test xml. kiwi uses RelaxNG and I think it would be good to adapt your schema to rng as well
I see your point. And you are right ...probably :) RelaxNG is quite complicated for me and xml schema is enough. But I will take a deeper look and give it a chance.
3) I have removed the use of global variables they are evil :) all parameters are passed as object parameters so you need to adapt the kiwi.pl adaption you have made a bit
good Idea, we will adopt you patches and fix kiwi.pl integration part and report back. I am setting needinfo on you. Please comment point 1) Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.