https://bugzilla.novell.com/show_bug.cgi?id=790557
https://bugzilla.novell.com/show_bug.cgi?id=790557#c4
Frederic Crozat changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fcrozat@suse.com
AssignedTo|fcrozat@suse.com |jweberhofer@weberhofer.at
--- Comment #4 from Frederic Crozat 2012-11-22 17:10:20 UTC ---
fail2ban startup seems pretty fragile (if rely on /var/run/fail2ban to be
empty, which might not be the case if the daemon ever crash and left some
previous files there) IMHO.
I would suggest three things to improve this :
- remove startproc usage to start fail2ban : there are at least 3 different PID
involved (since startproc will start fail2ban-client which will start
fail2ban-server which will daemonize). startproc returns errorcode 7, which
means "program is not running". Just remove startproc call and everything works
much better.
- add -x to startup line in initscript (already done in Fedora package), so
even if old socket / pid are left running, they won't prevent fail2ban to start
=>
line should be :
$FAIL2BAN_CLI -q $FAIL2BAN_OPTIONS start
- add : # PIDFile: /var/run/fail2ban/fail2ban.pid in the LSB header of the
initscript, to help systemd to monitor fail2ban server pid life.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.