https://bugzilla.novell.com/show_bug.cgi?id=219584 ------- Comment #7 from thoenig@novell.com 2007-01-18 11:22 MST ------- Matthias, the patch looks good, nice work. Just one remark: 40 + if (dbus_message_get_args(reply, 41 + NULL, 42 + DBUS_TYPE_STRING, &tmp_name, 43 + DBUS_TYPE_INVALID)) I'd spend some lines on proper error handling. Makes life easier whenever you run into issues. In our development versions, D-Bus will even cause ivman to exit if you pass NULL instead of an initialized DBusError. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.