http://bugzilla.novell.com/show_bug.cgi?id=500661 Summary: wvdial fails to retry on modem init string sending Classification: openSUSE Product: openSUSE 11.1 Version: Final Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: osv@kiae.ru QAContact: qa@suse.de Found By: --- Created an attachment (id=289746) --> (http://bugzilla.novell.com/attachment.cgi?id=289746) patch to solve the problem User-Agent: Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.10 (like Gecko) SUSE There is a trivial bug which is probably rather a typo in the wvdialer.cc code. The bug is in the modem init strings sending code below: modem->print( "%s\r", *this_str ); log( "Sending: %s\n", *this_str ); received = wait_for_modem( init_responses, 5000, true ); switch( received ) { case -1: modem->print( "ATQ0\r" ); log( "Sending: ATQ0\n" ); received = wait_for_modem( init_responses, 500, true ); modem->print( "%s\r", *this_str ); log( "Re-Sending: %s\n", *this_str ); received = wait_for_modem( init_responses, 5000, true ); switch( received ) { case -1: err( "Modem not responding.\n" ); return( false ); case 1: err( "Bad init string.\n" ); return( false ); } goto end_outer; The code's purpose is to send modem init strings such as "ATZ" at the beginning of the dialer session. As you see the code tries to resend an init string in case the was no response from the modem on the first try. The problem with the bug is the re-sending does not help even if the sending succeeds on the second try. This is due to "goto end_outer;" statement at the end of the above fragment. The statement makes the wvdial leave the init strings sending loop even after the re-sending succeeds. I guess it was a typo and the author's intention was to place "break;" statement here to proceed with sending the init strings. I did find this bug rather annoying due to my modem has a bad habit of not responding randomly on the first init string sent to it. It does respond when the string is resent, but the bug fails the wvdialer session anyway. I was forced to restart wvdial again and again until the modem's response to the first init string was catched from the first try. Finally I did find the bug and I am happy now thanks to the open source. Hopefully the fix will be in the next release. The patch for 1.56 is attached. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.