Marcus Moeller - 9:53 13.02.13 wrote:
Am 13.02.2013 09:05, schrieb Michal Hrusecky:
Marcus Moeller - 22:21 12.02.13 wrote:
...
From my perspective we had never defined which function-set must be supported by the theme and just remembered that ppl called for a userlist in 12.1 which I have added. Just to let you know, only a very few of KDM themes support functionalities like userlist or domain logon, even not the official ones from the KDE project. And we had all kind of themes in the past.
I have not followed the 12.2 KDM design which was driven by Bruno, but this seems to have these functions. Sadly it was not very well received from the design point of view.
This leads me to my final summary: Functionality should never be driven by design. All other Display Managers I know, split these aspects. This is why I think KDM is broken and should be fixed. This could be done by replacing it with LightDM (and don't argue with missing systemd patches. Afaik these are there, they are just not accepted upstream, which we could not expect as they are using upstart and ignore the rest).
If we want to stay with KDM, we should clearly define which functions must be supported. And again: don't expect that a designer will set up an Active Directory domain controller! If we want to support that, we need backed help from a technical contact.
What about taking Brunos theme which has all the functionality and letting only limited set of variable to be changed? We can make one extra config file, which will be simple and contain only basic stuff (colors, pictures, maybe few positions, ...) and in Makefile, we can fill in some variable for the full theme. So designers will be able to play as much as they want without breaking functionality.
The current theme now also support nearly all features. Maybe hiding of the userlist box could be added when 'Do not show userlist' option is set (patches welcome).
Basically what I read is that there is too much freedom in design of KDM and it is easy to break stuff you don't have. It should be possible to limit that freedom so stuff will not get broken and designers will know what they can change safely and what only if they are sure what are they doing and that they are not breaking stuff...
No, you are reading it wrong. The functionality should just not be driven by design, which means, every options should be available, no matter which theme is choosen.
A design should NEVER be able to break functionality!
Still, solution is the same and easy - make few elements fixed part of
the theme and don't let designer touch them. Either you limit what you
can do with design or you can screw up functionality with theme -
imagine white text on white background, overlapping inputs, buttons
outside of the screen...
--
Michal Hrusecky