Hi! On Tue, Mar 10, 2009 at 11:48:55AM -0300, aledr wrote:
On Tue, Mar 10, 2009 at 10:59 AM, Josef Reidinger
wrote: aledr wrote:
Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one?
Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"
Hi, I think that you should before send to contrib fix some rpmlint warnings like: openfire.i586: W: class-path-in-manifest /usr/share/openfire/lib/jtds.jar The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path. These entries do not work with older Java versions and even if they do work, they are inflexible and usually cause nasty surprises.
AFAIK this can be ignored. Michal: is that true?
openfire.i586: W: no-version-in-last-changelog openfire-doc.i586: W: no-version-in-last-changelog openfire.src: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it.
Ignore this one, too
openfire.i586: W: script-without-shebang /var/adm/fillup-templates/sysconfig.openfire This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.
Just remove the executable bit from that file - here's the diff: Index: openfire.spec =================================================================== --- openfire.spec (revision 023cdcef66751979644ad4536a1a528a) +++ openfire.spec (working copy) @@ -94,6 +94,7 @@ # Set up the sysconfig file. #------------------------------------------------------------------------------------ %{__install} -D %{buildroot}%{homedir}/bin/extra/redhat/openfire-sysconfig %{buildroot}/var/adm/fillup-templates/sysconfig.openfire +chmod -x %{buildroot}/var/adm/fillup-templates/sysconfig.openfire # Copy over the documentation. #------------------------------------------------------------------------------------
openfire.i586: W: unstripped-binary-or-object /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so openfire.i586: E: arch-dependent-file-in-usr-share (Badness: 590) /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files.
I guess that file isn't used in default installation, so maybe you could just move that to /usr/share/doc/packages/openfire/. Another option is to remove that file completely. I'm not sure, but perhaps the whole /usr/share/openfire/resources directory can be considered as addons/examples and thus can be moved to documentation directory. Please, whatever change you make, verify that the package still works, because what I wrote above is just an idea. Hope that helps... -- Best regards / s pozdravem Petr Uzel, Packages maintainer --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: puzel@suse.cz Lihovarská 1060/12 tel: +420 284 028 964 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org