Good day! I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one? Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
Hi aledr, On Dienstag 10 März 2009 14:10:34 aledr wrote:
Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one? You mean: osc sr create home:aledr openfire openSUSE:Factory:Contrib - m"add openfire" Is this what you mean?
-- Sincereley Yours Sascha Manns openSUSE Build Service openSUSE Marketing Team Maifeldstrasse 10 D-56 727 Mayen Email: Sascha.Manns@directbox.com Web: http://saschamanns.gulli.to Project-Blog: http://lizards.opensuse.org/author/saigkill Private-Blog: http://saschasbacktrace.blogspot.com PGP-Key: E31B59FB @ hkp://wwwkeys.pgp.net DISCLAIMER: Please note that in accordance with the German law on data retention, information on every electronic information exchange with me is retained for a period of six months. http://www.vorratsdatenspeicherung.de http://www.ccc.de
aledr wrote:
Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one?
Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"
Hi, I think that you should before send to contrib fix some rpmlint warnings like: openfire.i586: W: class-path-in-manifest /usr/share/openfire/lib/jtds.jar The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path. These entries do not work with older Java versions and even if they do work, they are inflexible and usually cause nasty surprises. openfire.i586: W: no-version-in-last-changelog openfire-doc.i586: W: no-version-in-last-changelog openfire.src: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. openfire.i586: W: script-without-shebang /var/adm/fillup-templates/sysconfig.openfire This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. openfire.i586: W: unstripped-binary-or-object /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so openfire.i586: E: arch-dependent-file-in-usr-share (Badness: 590) /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files. Also this lsb warning should be fixed: openfire: Name of init script "openfire" is not LSB conform Good luck with this huge package (I see you have better package then second openfire package which I found in buildservice). JR -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
On Tue, Mar 10, 2009 at 10:59 AM, Josef Reidinger
aledr wrote:
Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one?
Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"
Hi, I think that you should before send to contrib fix some rpmlint warnings like: openfire.i586: W: class-path-in-manifest /usr/share/openfire/lib/jtds.jar The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path. These entries do not work with older Java versions and even if they do work, they are inflexible and usually cause nasty surprises.
openfire.i586: W: no-version-in-last-changelog openfire-doc.i586: W: no-version-in-last-changelog openfire.src: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it.
openfire.i586: W: script-without-shebang /var/adm/fillup-templates/sysconfig.openfire This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.
openfire.i586: W: unstripped-binary-or-object /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so openfire.i586: E: arch-dependent-file-in-usr-share (Badness: 590) /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files.
Also this lsb warning should be fixed: openfire: Name of init script "openfire" is not LSB conform
I could fix this one only registering the init name with LANANA For now, I'm not able to fix the others lints.
Good luck with this huge package (I see you have better package then second openfire package which I found in buildservice). JR -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
-- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
Hi! On Tue, Mar 10, 2009 at 11:48:55AM -0300, aledr wrote:
On Tue, Mar 10, 2009 at 10:59 AM, Josef Reidinger
wrote: aledr wrote:
Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one?
Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"
Hi, I think that you should before send to contrib fix some rpmlint warnings like: openfire.i586: W: class-path-in-manifest /usr/share/openfire/lib/jtds.jar The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path. These entries do not work with older Java versions and even if they do work, they are inflexible and usually cause nasty surprises.
AFAIK this can be ignored. Michal: is that true?
openfire.i586: W: no-version-in-last-changelog openfire-doc.i586: W: no-version-in-last-changelog openfire.src: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it.
Ignore this one, too
openfire.i586: W: script-without-shebang /var/adm/fillup-templates/sysconfig.openfire This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.
Just remove the executable bit from that file - here's the diff: Index: openfire.spec =================================================================== --- openfire.spec (revision 023cdcef66751979644ad4536a1a528a) +++ openfire.spec (working copy) @@ -94,6 +94,7 @@ # Set up the sysconfig file. #------------------------------------------------------------------------------------ %{__install} -D %{buildroot}%{homedir}/bin/extra/redhat/openfire-sysconfig %{buildroot}/var/adm/fillup-templates/sysconfig.openfire +chmod -x %{buildroot}/var/adm/fillup-templates/sysconfig.openfire # Copy over the documentation. #------------------------------------------------------------------------------------
openfire.i586: W: unstripped-binary-or-object /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so openfire.i586: E: arch-dependent-file-in-usr-share (Badness: 590) /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files.
I guess that file isn't used in default installation, so maybe you could just move that to /usr/share/doc/packages/openfire/. Another option is to remove that file completely. I'm not sure, but perhaps the whole /usr/share/openfire/resources directory can be considered as addons/examples and thus can be moved to documentation directory. Please, whatever change you make, verify that the package still works, because what I wrote above is just an idea. Hope that helps... -- Best regards / s pozdravem Petr Uzel, Packages maintainer --------------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: puzel@suse.cz Lihovarská 1060/12 tel: +420 284 028 964 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
Petr Uzel wrote:
Hi!
On Tue, Mar 10, 2009 at 11:48:55AM -0300, aledr wrote:
On Tue, Mar 10, 2009 at 10:59 AM, Josef Reidinger
wrote: Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one?
Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" Hi, I think that you should before send to contrib fix some rpmlint warnings like: openfire.i586: W: class-path-in-manifest /usr/share/openfire/lib/jtds.jar The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path. These entries do not work with older Java versions and even if they do work,
aledr wrote: they are inflexible and usually cause nasty surprises.
AFAIK this can be ignored. Michal: is that true?
I look at this problem and I must say that I don't understand why rpm complain, class-file looks fine for me -> Class-Path: jcifs.jar same as write sun in his documentation http://java.sun.com/j2se/1.5.0/docs/guide/jar/jar.html#Manifest Specification and example http://java.sun.com/docs/books/tutorial/deployment/jar/downman.html So it is maybe bug in check I think, because I expect after this warning full path specify e.g. /usr/share/utfg.jar which is bad. -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
On Tuesday 10 of March 2009 14:10:34 aledr wrote:
Good day!
I've been working for a while in the openfire RPM and need to review It to create a request for the contrib repo. It's at my home repo (home:aledr). Who can help me with this one?
Thanks in advance. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"
Hi, I looked through a build log of openfire. The classpath issue should be ignored (anyone uses that old JVMs). See Packaging/Java [1] (it's a new Packaging documentation based on Fedora docs) for help, if you would like to remove it. But it's not serious. More problematic is a openfire.i586: W: unstripped-binary-or-object /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so openfire.i586: E: arch-dependent-file-in-usr-share (Badness: 590) /usr/share/openfire/resources/nativeAuth/linux-i386/libshaj.so This package installs an ELF binary in the /usr/share hierarchy, which is reserved for architecture-independent files. The libhsaj.so should be placed into %{_libdir}, but as it's loaded using System.loadLibrary() (Java equivalent of dlopen()), the better place is %{_jnidir} -> %{_libdir}/java. But I didn't use it for matthewlib-java (it also uses a JNI files), so %{_libdir} is examined way. But I'd be happy, if you will test a %{_jnidir} ;-) That also means - this package cannot have BuildArch: noarch. Documentation: Packaging/Java [2], matthewlib-java.spec [3] [1] http://en.opensuse.org/Packaging/Java#class-path-in-manifest [2] http://en.opensuse.org/Packaging/Java#Packaging_JAR_files_that_use_JNIhttp:/... [3] https://build.opensuse.org/package/view_file?file=matthewlib- java.spec&package=matthewlib-java&project=openSUSE:Factory Regards Michal Vyskocil -- To unsubscribe, e-mail: opensuse-contrib+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-contrib+help@opensuse.org
participants (5)
-
aledr
-
Josef Reidinger
-
Michal Vyskocil
-
Petr Uzel
-
Sascha Manns