Hi Jano, [sorry you get this twice] On Wed, 3 Sep 2008, jkupec@svn.opensuse.org wrote:
Log: - skip repositories with non-matching target distro when reading repoindex
@@ -98,6 +103,19 @@ if ( reader_r->name() == "repo" ) { XmlString s; + + // skip repositories with unknown or not matching target distribution + s = reader_r->getAttribute("distro_target"); + if (!s.get() || _target_distro != s.asString()) + { + MIL + << "Skipping repository meant for '" + << (s.get() ? s.asString() : "(not specified)") + << "' distribution (current distro is '" << _target_distro << "')." + << endl; + return true; + } +
If I understand the code correctly I don't think this is a good idea. If the repofile doesn't have any entry for "distro_target" it will be skipped. I rather would think that this is supposed to mean "don't care". Even _if_ it has a target-distro set (that's a new concept anyway, right?) why should we reject to use it? E.g. if it's completely self-contained (in the sense of only having external dependencies on, say, libc), like I would expect with some vendor repos, I can and want to use it on all distros. Also, how is the name matched? Above it's a string comparison. But 11.1 and SLES11 will be roughly the same, for instance. To me it sounds more a feature needlessly annoying users. What's the purpose of this? Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org