On Wed, Apr 09, Jan Kupec wrote:
My questions: - shouldn't dataiterator_init return int (0 on success, non-zero in error)?
If it can fail to setup the query, yes.
- should PoolQuery::ResultIterator::begin() ever throw? shouldn't it just log the incident and return end()?
There must be a way to discern a malformed query and an empty result. If you don't throw you must ofer an other way to detect this, but IMO is ok to throw here. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org