Mailinglist Archive: yast-devel (63 mails)

< Previous Next >
Re: [yast-devel] Yast and Rubocop? 80 columns
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 1.12.2014 v 10:01 Martin Vidner napsal(a):
- Limit lines to 80 characters.
https://github.com/bbatsov/ruby-style-guide#80-character-limits

Unfortunately there is no rationale for it or any details why...

[...]
https://github.com/yast/yast-yast2/commit/b3ff10aebd39aa0a446e6d7004fbe5821ec05f91

As you can see, you cannot see the text because the GitHub formatting cuts it
off. (On my 1920 pixel wide display, the diff viewport is 820 pixels no matter
how I resize the browser window.) I solved it by applying the style guide rule
and made it fit to 80 columns, since I was editing the text anyway.

I have tested it [1] and GitHub is able to display about 110-115 characters
per line (depending on the browser, in chrome I could see 111 characters, in
Firefox
115, but might depend on available fonts, display resolution etc...)

So from the GitHub POV the practical limit seems to be 110 characters.



[1] https://github.com/lslezak/yast-ntp-client/pull/3/files

- --

Ladislav Slez√°k
Appliance department / YaST Developer
Lihovarsk√° 1060/12
190 00 Prague 9 / Czech Republic
tel: +420 284 028 960
lslezak@xxxxxxxx
SUSE
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJUfEF4AAoJEHHp6jkF1zbPn9kH/Ar79ASTcYVbKAgJXTxV5rOS
GMD16k+mmZQ8WzaodzJoXEcRAUOgr75DAV+h587dUSsMNbwLEUH1wBHIZ3I6L0T4
jeEruHx4dps79PQqJE+TGP9PWobaYibLsZZ2+n0Qv5NPlW5eXlCUsRct3v1HY/kU
3I1UJbOTc5C6PAEskQNjE4CaeMXh/SRPsEo+JWZUQOxm2FUCAkD1axh+aoQQtyDk
XIp3tYqdAz6cYsU0+bDLGS2w1ijOMfFeApksNxhjiCtsQupddyqSuqrmnIKXzot1
lzPHskrlqzE3i1+NYx/O3L/vavnIVfJd4DBFz90A5fFjnZ1ehSdyjvNw4O9unpw=
=cZUd
-----END PGP SIGNATURE-----
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: yast-devel+owner@xxxxxxxxxxxx

< Previous Next >
List Navigation
References