Mailinglist Archive: yast-devel (66 mails)

< Previous Next >
Re: [yast-devel] What about comments for YCP to Ruby conversion?
  • From: Thomas Goettlicher <tgoettlicher@xxxxxxx>
  • Date: Tue, 18 Jun 2013 08:05:57 +0200
  • Message-id: <51BFF8C5.2070208@suse.de>
On 06/06/2013 04:10 PM, Johannes Meixner wrote:

Hello,

On Jun 6 15:12 Josef Reidinger wrote (excerpt):
I look forward to having openSUSE 13.1 (and then also SLE12) without
YCP!

Thanks for support. I hope result will satisfy you.

I already looked at the currently generated Ruby code
and I am impressed how well I can understand it
(at least on a first glance).
You should keep in mind that the translated ruby code is in ycp style. If a ruby expert writes code it even looks cleaner.
Please learn ruby by reading real ruby code.

I expected much less from automatically generated code.

With comments the resulting Ruby code will satisfy me.


Your proposal sound interesting, but there is problem, that you cannot
easily change comments into statement like
string ___comment = "something";

because comments occur on various places like
a && /* comment */ b

No - programmes do not do that - never - really never ever!
;-)

Out of curiosity I did a quick search on an older YaST SVN checkout
on my local machine for this particular case and got those:
--------------------------------------------------------------------------

apparmor/src/clients/apparmor.ycp:
Label::BackButton(), /* Label::FinishButton() */ _("&Launch"));

reipl/src/Reipl.ycp:
//ccw_map["parm"] = ""; /* SLES 11 and z/VM only */ // read only

network/src/clients/network.ycp:
Label::BackButton(), /* Label::FinishButton() */ _("&Launch"));

network/src/lan/hardware.ycp:
// NetworkModules::Alias /* FIXME: MOD Lan::Module["module"] */ = card["module"]:"";

network/src/lan/hardware.ycp:
// NetworkModules::Options /* FIXME: MOD Lan::Module["options"] */ = card["options"]:"";

firewall/src/dialogs.ycp:
"masquerading", "broadcast_simple", /* "ipsec_support", */ "logging_level", "custom_rules" ];

--------------------------------------------------------------------------

None of those has a real comment that explains any reason
why there is that inline comment.

Unbelievable!


Kind Regards
Johannes Meixner


--
Thomas Goettlicher
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer,
HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany

--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: yast-devel+owner@xxxxxxxxxxxx

< Previous Next >