Mailinglist Archive: yast-devel (46 mails)

< Previous Next >
[yast-devel] Re: [yast-commit] r64771 - in /trunk/fcoe-client/src: complex.ycp fcoe-client_finish.ycp
Dne 8.7.2011 10:44, gs@xxxxxxxxxxxxxxxxx napsal(a):
--- trunk/fcoe-client/src/complex.ycp (original)
+++ trunk/fcoe-client/src/complex.ycp Fri Jul 8 10:44:04 2011
@@ -332,13 +332,13 @@
else
{
command = sformat( "fipvlan -c -s %1", dev_name ); //
create and start FCoE
- create_ifcfg = true;
+ // create_ifcfg = true;

Please, no commented code. If the commented code is not valid anymore simply
delete
it (it can be reanimated from VCS history in the future if you need it back,
just use meaningful commit message to find it easily).

If it's a temporary fix then add a comment why it was commented and when it can
be
enabled again.


--

Best Regards

Ladislav Slez√°k
Yast Developer
------------------------------------------------------------------------
SUSE LINUX, s.r.o. e-mail: lslezak@xxxxxxx
Lihovarsk√° 1060/12 tel: +420 284 028 960
190 00 Prague 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages