Mailinglist Archive: yast-devel (163 mails)

< Previous Next >
[yast-devel] Re: [yast-commit] <rest-service> master : Change calling conventions for Invalid parameters to follow DRY
  • From: Klaus Kaempf <kkaempf@xxxxxxx>
  • Date: Tue, 22 Sep 2009 10:33:05 +0200
  • Message-id: <20090922083305.GA20100@xxxxxxxxxxxxx>
* Josef Reidinger <jreidinger@xxxxxxx> [Sep 22. 2009 10:29]:
else
logger.warn("No argument to update")
- raise InvalidParameters.new [{:name => "language", :error =>
"Missing"}]
+ raise InvalidParameters.new :language => "Missing"

This is looking way better now, thanks Josef.

Now I wonder if the "Missing" string shouldn't be replaced by a
constant to make its semantic meaning clearer ?!

Klaus
---
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N├╝rnberg)

--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups