Mailinglist Archive: yast-devel (73 mails)

< Previous Next >
[yast-devel] repodata.c - clarification
  • From: "Roberto Mannai" <robermann@xxxxxxxxx>
  • Date: Sat, 16 Aug 2008 16:06:33 +0200
  • Message-id: <414e44f70808160706v48275242mc17331aca3632feb@xxxxxxxxxxxxxx>
Hi
I'm writting a patch about the bug:
https://bugzilla.novell.com/show_bug.cgi?id=399239 - "YaST's software
installation modules should show disk space modification". The patch
would be an append in the tooltip on the "Free space" column in the
disk usage widget, like "Used XX GB - Installing x MB" or " - Removing
x MB". When the user makes a selection for install / removal, I keep a
counter of disk usage delta.

However I saw that for some packages, the variable
zypp::DiskUsageCounter::MountPoint.pkg_size returns 0. Going deeper I
saw that "repodata_search" method in "repodata.c" returns in this
instruction:

for (kp = keyp; (k = *kp++) != 0; )
if (data->keys[k].name == keyname) break;
if (k == 0) return;

So, for packages like "kernel-rt", "miro" and "kernel-source", I have
k == 0, going on no disk usage is computed (no call to pool.c -
solver_fill_DU_cb). I'm using the revision 10814 on svn.

A quick test case is selecting the "kernel-source" for installation:
the disk usage bar does not change (nor the percentage).

Is this behaviour wanted (for some condition on Repodata objects) or
is it a bug? Is this related to
https://bugzilla.novell.com/show_bug.cgi?id=375104 ?

Best regards
Roberto Mannai
--
To unsubscribe, e-mail: yast-devel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-devel+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages