[yast-commit] [yast/yast-yast2] 479182: Add a fetcher to extract license from an RPM packa...

From now on, the fetcher to get the license content is not be given as a

Branch: refs/heads/master Home: https://github.com/yast/yast-yast2 Commit: 4791820d87f6ddc79cb94b603eb91783be426cf4 https://github.com/yast/yast-yast2/commit/4791820d87f6ddc79cb94b603eb91783be... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/Makefile.am M library/packages/src/lib/y2packager/licenses_fetchers.rb A library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb M library/packages/test/Makefile.am A library/packages/test/y2packager/licenses_fetchers/rpm_test.rb Log Message: ----------- Add a fetcher to extract license from an RPM package Commit: 90cc3f01dcb7be2e6746f63f067ee50850c40f0b https://github.com/yast/yast-yast2/commit/90cc3f01dcb7be2e6746f63f067ee50850... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/license.rb M library/packages/src/lib/y2packager/licenses_fetchers.rb M library/packages/src/lib/y2packager/licenses_fetchers/base.rb M library/packages/src/lib/y2packager/licenses_fetchers/libzypp.rb M library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb M library/packages/src/lib/y2packager/product.rb M library/packages/src/lib/y2packager/product_license.rb M library/packages/test/Makefile.am M library/packages/test/y2packager/license_test.rb A library/packages/test/y2packager/licenses_fetchers/libzypp_test.rb M library/packages/test/y2packager/licenses_fetchers/rpm_test.rb A library/packages/test/y2packager/licenses_fetchers/shared_examples.rb Log Message: ----------- Use the first valid fetcher to get the license parameter. Instead, it will be the first one able to get it. Commit: ec037387c9c6a8f54ec932093032e182b98b1d4a https://github.com/yast/yast-yast2/commit/ec037387c9c6a8f54ec932093032e182b9... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/license.rb M library/packages/src/lib/y2packager/licenses_fetchers/libzypp.rb M library/packages/test/y2packager/licenses_fetchers/libzypp_test.rb Log Message: ----------- Add test for LocalesFetchers::Libzypp#locales Commit: c3c4857c43689e5c35cca67fb7c7519d226dc4ed https://github.com/yast/yast-yast2/commit/c3c4857c43689e5c35cca67fb7c7519d22... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/license.rb M library/packages/test/y2packager/license_test.rb Log Message: ----------- Fix the License#locales test Commit: e17287a42081dbc12ab724f2d4d9b0702fa9c5f1 https://github.com/yast/yast-yast2/commit/e17287a42081dbc12ab724f2d4d9b0702f... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/Makefile.am M library/packages/src/lib/y2packager/license.rb M library/packages/src/lib/y2packager/licenses_fetchers/libzypp.rb M library/packages/src/lib/y2packager/licenses_handlers.rb A library/packages/src/lib/y2packager/licenses_handlers/rpm.rb M library/packages/src/lib/y2packager/product_license.rb M library/packages/test/Makefile.am M library/packages/test/y2packager/license_test.rb M library/packages/test/y2packager/licenses_handlers/libzypp_test.rb A library/packages/test/y2packager/licenses_handlers/rpm_test.rb M library/packages/test/y2packager/product_license_test.rb M library/packages/test/y2packager/product_test.rb Log Message: ----------- Add a handler for licenses fetched from an RPM package Basically, because it is necessary to know if the license acceptance is required. The way to check it is looking for the `no-acceptance-needed` file inside the RPM, which presence means that the license does not need to be accepted. This change also implies a few adjustments in the existing codebase. Commit: 55e66236a4bd1646763c448f5c1804bcecaccf69 https://github.com/yast/yast-yast2/commit/55e66236a4bd1646763c448f5c1804bcec... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb Log Message: ----------- Make Rubocop happy Due to the default configuration (aligned vs indented) for the Style/MultilineMethodCallIndentation cop, which is available under the Layout department since Rubocop 0.49 (https://github.com/rubocop-hq/rubocop/pull/4278) Commit: f975940479e013b20d4d137af227e9c1022560fc https://github.com/yast/yast-yast2/commit/f975940479e013b20d4d137af227e9c102... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb M library/packages/test/y2packager/licenses_fetchers/rpm_test.rb Log Message: ----------- Include the default lang in LicensesFetchers::Rpm#locales Since it is possible to have the "LICENSE.TXT" file, without the language code, which usually represents the license for the default language. This change is needed to keep consistent between the displayed license content and the selected language in the license agreement dialog[1], avoiding to select the first one because of the absence of proper value. [1] https://github.com/yast/yast-packager/blob/e625f6ea375b9ffbc82eddae8774d0664... Commit: 2a1ed8ac6c3489069de682b6011e25323d17f7b8 https://github.com/yast/yast-yast2/commit/2a1ed8ac6c3489069de682b6011e25323d... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/licenses_fetchers.rb M library/packages/src/lib/y2packager/licenses_handlers.rb Log Message: ----------- Fix methods documentation Commit: 5ba3e9aff69258d4fdeb7bdcb5265798e1236629 https://github.com/yast/yast-yast2/commit/5ba3e9aff69258d4fdeb7bdcb5265798e1... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/license.rb M library/packages/src/lib/y2packager/licenses_fetchers.rb M library/packages/src/lib/y2packager/licenses_fetchers/base.rb M library/packages/src/lib/y2packager/licenses_fetchers/libzypp.rb M library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb M library/packages/src/lib/y2packager/licenses_handlers.rb M library/packages/src/lib/y2packager/licenses_handlers/rpm.rb M library/packages/test/y2packager/licenses_fetchers/rpm_test.rb M library/packages/test/y2packager/licenses_handlers/rpm_test.rb Log Message: ----------- Update from code review Commit: a3497be55b4964cd427193a00171234e6538a131 https://github.com/yast/yast-yast2/commit/a3497be55b4964cd427193a00171234e65... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: A library/packages/test/data/rpm/fallback_licenses_test_package-0.1-0.noarch.rpm A library/packages/test/data/rpm/fallback_licenses_test_package.spec A library/packages/test/data/rpm/licenses_test_package-0.1-0.noarch.rpm A library/packages/test/data/rpm/licenses_test_package.spec M library/packages/test/y2packager/licenses_fetchers/rpm_test.rb Log Message: ----------- Improve the LicensesFetchers::Rpm tests Using less mocks as suggested in the code review. Commit: cd2af10eaa4940d5177510fcb7f954df58a7d68c https://github.com/yast/yast-yast2/commit/cd2af10eaa4940d5177510fcb7f954df58... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb M library/packages/src/lib/y2packager/licenses_handlers/rpm.rb M library/packages/src/lib/y2packager/package.rb M library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb M library/packages/test/y2packager/package_test.rb Log Message: ----------- Add new class method to get the highest available or selected version of a package Because the code was duplicated in three different classes, a new Y2Packager::Package.last_version class method has been added. Commit: 746a685c7ab2d4c636bb2bf87f39343c0c48d8ea https://github.com/yast/yast-yast2/commit/746a685c7ab2d4c636bb2bf87f39343c0c... Author: David Díaz González Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M package/yast2.changes M package/yast2.spec Log Message: ----------- Update version and changelog Commit: 43e6c8f37489246f8c9eca16d5d77d4d33d598ff https://github.com/yast/yast-yast2/commit/43e6c8f37489246f8c9eca16d5d77d4d33... Author: David Díaz <1691872+dgdavid@users.noreply.github.com> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M library/packages/src/Makefile.am M library/packages/src/lib/y2packager/license.rb M library/packages/src/lib/y2packager/licenses_fetchers.rb M library/packages/src/lib/y2packager/licenses_fetchers/base.rb M library/packages/src/lib/y2packager/licenses_fetchers/libzypp.rb A library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb M library/packages/src/lib/y2packager/licenses_handlers.rb A library/packages/src/lib/y2packager/licenses_handlers/rpm.rb M library/packages/src/lib/y2packager/package.rb M library/packages/src/lib/y2packager/product.rb M library/packages/src/lib/y2packager/product_license.rb M library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb M library/packages/test/Makefile.am A library/packages/test/data/rpm/fallback_licenses_test_package-0.1-0.noarch.rpm A library/packages/test/data/rpm/fallback_licenses_test_package.spec A library/packages/test/data/rpm/licenses_test_package-0.1-0.noarch.rpm A library/packages/test/data/rpm/licenses_test_package.spec M library/packages/test/y2packager/license_test.rb A library/packages/test/y2packager/licenses_fetchers/libzypp_test.rb A library/packages/test/y2packager/licenses_fetchers/rpm_test.rb A library/packages/test/y2packager/licenses_fetchers/shared_examples.rb M library/packages/test/y2packager/licenses_handlers/libzypp_test.rb A library/packages/test/y2packager/licenses_handlers/rpm_test.rb M library/packages/test/y2packager/package_test.rb M library/packages/test/y2packager/product_license_test.rb M library/packages/test/y2packager/product_test.rb M package/yast2.changes M package/yast2.spec Log Message: ----------- Merge pull request #880 from yast/feature/fate-325482-display-the-license Display the license contained in the fallback repo Compare: https://github.com/yast/yast-yast2/compare/45bc1b83e849...43e6c8f37489 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.