[yast-commit] [yast/yast-yast2] 562e2f: Rubocop update (#478)

Branch: refs/heads/master Home: https://github.com/yast/yast-yast2 Commit: 562e2f3ccfa8413a0528cf067ea7533fa72a2450 https://github.com/yast/yast-yast2/commit/562e2f3ccfa8413a0528cf067ea7533fa7... Author: Ladislav Slezák Date: 2016-07-15 (Fri, 15 Jul 2016) Changed paths: M .rubocop.yml M .travis.yml M library/commandline/src/modules/CommandLine.rb M library/commandline/test/clients/dummy_cmdline.rb M library/commandline/testsuite/tests/interactive4.rb M library/control/src/modules/DebugHooks.rb M library/control/src/modules/InstError.rb M library/control/src/modules/ProductControl.rb M library/control/src/modules/ProductFeatures.rb M library/control/src/modules/WorkflowManager.rb M library/control/test/ProductFeatures_test.rb M library/control/testsuite/tests/ProductProfile.rb M library/control/testsuite/tests/restore.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/CWMTable.rb M library/cwm/src/modules/CWMTsigKeys.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/cwm/testsuite/tests/t1.rb M library/cwm/testsuite/tests/t2.rb M library/general/src/lib/ui/event_dispatcher.rb M library/general/src/lib/ui/service_status.rb M library/general/src/modules/Arch.rb M library/general/src/modules/AsciiFile.rb M library/general/src/modules/Assert.rb M library/general/src/modules/CustomDialogs.rb M library/general/src/modules/Distro.rb M library/general/src/modules/DontShowAgain.rb M library/general/src/modules/FileUtils.rb M library/general/src/modules/Hooks.rb M library/general/src/modules/Linuxrc.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Mode.rb M library/general/src/modules/OSRelease.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Stage.rb M library/general/src/modules/Summary.rb M library/general/src/modules/ValueBrowser.rb M library/general/test/asciifile_test.rb M library/general/test/linuxrc_test.rb M library/general/testsuite/tests/FileUtils.rb M library/gpg/src/modules/GPG.rb M library/gpg/src/modules/GPGWidgets.rb M library/log/examples/logviewcore1.rb M library/log/examples/logviewcore2.rb M library/log/examples/logviewcore3.rb M library/log/src/modules/LogView.rb M library/log/src/modules/LogViewCore.rb M library/network/src/lib/network/firewalld.rb M library/network/src/lib/network/susefirewall.rb M library/network/src/lib/network/susefirewall2.rb M library/network/src/lib/network/susefirewall2services.rb M library/network/src/lib/network/susefirewalld.rb M library/network/src/lib/network/susefirewalldservices.rb M library/network/src/lib/network/susefirewallservices.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/NetworkService.rb M library/network/src/modules/PortAliases.rb M library/network/src/modules/PortRanges.rb M library/network/src/modules/SuSEFirewall.rb M library/network/test/load_ipv6_cfg_test.rb M library/network/test/network_interfaces_helpers_test.rb M library/network/test/susefirewalld_test.rb M library/network/testsuite/tests/PortAliases.rb M library/network/testsuite/tests/SuSEFirewall.rb M library/packages/src/include/packages/common.rb M library/packages/src/lib/packages/dummy_callbacks.rb M library/packages/src/lib/packages/repository.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageLock.rb M library/packages/src/modules/PackageSystem.rb M library/packages/src/modules/PackagesUI.rb M library/packages/src/modules/Product.rb M library/packages/src/modules/SignatureCheckCallbacks.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/packages/test/dummy_callbacks_test.rb M library/packages/test/lib/product_test.rb M library/packages/test/package_callbacks_test.rb M library/packages/test/product_test.rb M library/runlevel/src/modules/Service.rb M library/runlevel/test/service_test.rb M library/runlevel/testsuite/tests/Systemd.rb M library/sequencer/doc/examples/examples.rb M library/sequencer/src/modules/Sequencer.rb M library/sequencer/testsuite/tests/WS_check.rb M library/sequencer/testsuite/tests/Wizard0.rb M library/system/src/lib/yast2/fs_snapshot.rb M library/system/src/modules/FileChanges.rb M library/system/src/modules/Initrd.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/system/src/modules/ModulesConf.rb M library/system/test/fs_snapshot_test.rb M library/system/testsuite/tests/filechanges.rb M library/system/testsuite/tests/initrd.rb M library/system/testsuite/tests/kernel.rb M library/systemd/src/lib/yast2/systemctl.rb M library/systemd/src/lib/yast2/systemd_unit.rb M library/systemd/src/modules/systemd_service.rb M library/systemd/src/modules/systemd_socket.rb M library/systemd/src/modules/systemd_target.rb M library/systemd/test/test_helper.rb M library/types/src/modules/IP.rb M library/types/src/modules/Netmask.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/RichText.rb M library/types/src/modules/String.rb M library/types/src/modules/TypeRepository.rb M library/types/src/modules/URL.rb M library/types/src/modules/URLRecode.rb M library/types/test/ip_test.rb M library/types/test/string_test.rb M library/wizard/src/modules/Confirm.rb M library/wizard/src/modules/Progress.rb M library/wizard/src/modules/Wizard.rb M library/xml/src/modules/XML.rb M test/test_helper.rb Log Message: ----------- Rubocop update (#478) * Fixed Style/MutableConstant * Fixed Performance/RangeInclude * Fixed Style/EmptyLineBetweenDefs * Fixed Style/ExtraSpacing * Fix Style/AlignHash * Fixed Style/ClosingParenthesisIndentation * Fixed Style/SpaceAfterNot * Fixed Style/NestedModifier * Fixed Style/ParenthesesAroundCondition * Fixed Style/ConditionalAssignment * Manual refactoring/clean up * Fixed Style/ElseAlignment * Manually fixed Style/IdenticalConditionalBranches * Fixed Style/IndentationWidth * Manually fixed Lint/UselessAssignment * Fixed Style/CommentIndentation * Fixed Style/RedundantParentheses * Fixed Style/SymbolLiteral * Manually fixed Style/GuardClause * Manually fixed Style/IfInsideElse * Fixed Style/RedundantReturn * Manually fixed Style/NestedParenthesizedCalls * Fixed Style/ExtraSpacing * Fixed Style/EmptyElse * Fixed Style/Alias * Fixed Performance/Casecmp * Fixed Style/CommentIndentation * Manually fixed Style/MultilineTernaryOperator * Fixed Style/ElseAlignment * Fixed Performance/RedundantMatch * Manually fixed Lint/UnneededDisable * Fixed Style/TrailingWhitespace * Manually fixed Lint/UselessAssignment * Manually fixed Lint/EndAlignment * Fixed Style/MultilineMethodCallBraceLayout * Fixed Style/IndentationWidth * Fixed Style/CaseIndentation * Fixed Style/IndentAssignment * Manually fixed Style/OptionalArguments Fortunately the default value is never used in the YaST code. * Manually fixed Lint/UselessAccessModifier * Use new Rubocop at Travis * Added Metrics/ModuleLength limit * Fixed Style/ZeroLengthPredicate * Fixed Style/ElseAlignment * Fixed Style/IndentationWidth * Fixed Style/CommentIndentation * Manually fixed Lint/EndAlignment * Fixed Style/IndentArray * Fixed Style/Alias * Fixed Style/SpaceInsidePercentLiteralDelimiters * Fixed Style/ClosingParenthesisIndentation * Increase the Metrics/MethodLength limit Ok, it's a bit cheating... * Update Rubocop at Travis * Code review fixes * Fixed translation comment