Mailinglist Archive: yast-commit (1271 mails)

< Previous Next >
[yast-commit] [ci_new_pac] JFYI yast2-ntp-client -> sle12
Script 'mail_helper' called by ro
Hello packager,

This is just FYI. Your package was checked in in distribution "sle12"
by autobuild-member: ro.

Here comes the log...

---------------------------%<------------------------------
Hi,

here is the log from ci_new_pac /mounts/work_src_done/SLE12/yast2-ntp-client ->
sle12



## BNC# 893065 : "[country] "Synchronize now" and "NTP Server Address" appear
misaligned" (ASSIGNED/)
## BNC# 893094 : "Invalid NTP server can be used for NTP sync, no error shown"
(ASSIGNED/)

Changes:
--------
--- /work/SRC/SUSE:SLE-12:GA/yast2-ntp-client/yast2-ntp-client.changes
2014-08-22 15:43:42.000000000 +0200
+++ /mounts/work_src_done/SLE12/yast2-ntp-client/yast2-ntp-client.changes
2014-09-02 09:48:34.000000000 +0200
@@ -1,0 +2,7 @@
+Mon Sep 1 15:34:23 UTC 2014 - cwh@xxxxxxxx
+
+- Aligned "Synchronize now" button and "NTP Server Address" box (bnc#893065)
+- Fixed checking of return value of "sntp -s" (bnc#893094)
+- 3.1.11
+
+-------------------------------------------------------------------

calling whatdependson for sle12-i586
Packages directly triggered for rebuild:
- yast2-ntp-client
- yast2-schema
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/SUSE:SLE-12:GA/yast2-ntp-client (Old)
and /mounts/work_src_done/SLE12/yast2-ntp-client (BS:build ID:43349
MAIL:yast-commit@xxxxxxxxxxxx) (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-ntp-client", Maintainer is "yast-commit@xxxxxxxxxxxx"


Old:
----
yast2-ntp-client-3.1.10.tar.bz2

New:
----
yast2-ntp-client-3.1.11.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-ntp-client.spec ++++++
--- /var/tmp/diff_new_pack.XmleWS/_old 2014-09-02 15:57:11.000000000 +0200
+++ /var/tmp/diff_new_pack.XmleWS/_new 2014-09-02 15:57:11.000000000 +0200
@@ -17,7 +17,7 @@


Name: yast2-ntp-client
-Version: 3.1.10
+Version: 3.1.11
Release: 0
Summary: YaST2 - NTP Client Configuration
License: GPL-2.0+

++++++ yast2-ntp-client-3.1.10.tar.bz2 -> yast2-ntp-client-3.1.11.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-3.1.10/package/yast2-ntp-client.changes
new/yast2-ntp-client-3.1.11/package/yast2-ntp-client.changes
--- old/yast2-ntp-client-3.1.10/package/yast2-ntp-client.changes
2014-08-20 16:49:51.000000000 +0200
+++ new/yast2-ntp-client-3.1.11/package/yast2-ntp-client.changes
2014-09-02 09:44:18.000000000 +0200
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Mon Sep 1 15:34:23 UTC 2014 - cwh@xxxxxxxx
+
+- Aligned "Synchronize now" button and "NTP Server Address" box (bnc#893065)
+- Fixed checking of return value of "sntp -s" (bnc#893094)
+- 3.1.11
+
+-------------------------------------------------------------------
Wed Aug 20 16:27:49 CEST 2014 - schubi@xxxxxxx

- Autoyast cloning: Do not show error popup if ntp server has not
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-3.1.10/package/yast2-ntp-client.spec
new/yast2-ntp-client-3.1.11/package/yast2-ntp-client.spec
--- old/yast2-ntp-client-3.1.10/package/yast2-ntp-client.spec 2014-08-20
16:49:51.000000000 +0200
+++ new/yast2-ntp-client-3.1.11/package/yast2-ntp-client.spec 2014-09-02
09:44:18.000000000 +0200
@@ -17,7 +17,7 @@


Name: yast2-ntp-client
-Version: 3.1.10
+Version: 3.1.11
Release: 0
Summary: YaST2 - NTP Client Configuration
License: GPL-2.0+
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-3.1.10/src/clients/ntp-client_proposal.rb
new/yast2-ntp-client-3.1.11/src/clients/ntp-client_proposal.rb
--- old/yast2-ntp-client-3.1.10/src/clients/ntp-client_proposal.rb
2014-08-20 16:49:51.000000000 +0200
+++ new/yast2-ntp-client-3.1.11/src/clients/ntp-client_proposal.rb
2014-09-02 09:44:18.000000000 +0200
@@ -231,6 +231,7 @@
HWeight(
1,
VBox(
+ VSpacing(0.5),
Left(
ComboBox(
Id(:ntp_address),
@@ -264,7 +265,6 @@
1,
VBox(
Label(""),
- VSpacing(0.3), # try to line up the widgets horizontally
# push button label
Left(PushButton(Id(:ntp_now), _("S&ynchronize now"))),
VSpacing(0.3),
@@ -350,23 +350,21 @@
# return:
# `success, `invalid_hostname or `ntpdate_failed
def Write(param)
- param = deep_copy(param)
- ret = nil
- ntp_servers = Ops.get_list(param, "servers", [])
- ntp_server = Ops.get_string(param, "server", "")
- run_service = Ops.get_boolean(param, "run_service", true)
+ ntp_servers = param["servers"] || []
+ ntp_server = param["server"] || ""
+ run_service = param["run_service"] || true
if ntp_server == ""
# get the value from UI only when it wasn't given as a parameter
- ntp_server = Convert.to_string(UI.QueryWidget(Id(:ntp_address),
:Value))
+ ntp_server = UI.QueryWidget(Id(:ntp_address), :Value)
end
return :invalid_hostname if !ValidateSingleServer(ntp_server)

WriteNtpSettings(ntp_servers, ntp_server, run_service)
- return :success if Ops.get_boolean(param, "write_only", false)
+ return :success if param["write_only"]

# One-time adjusment without running the ntp daemon
# Meanwhile, ntpdate was replaced by sntp
- ntpdate_only = Ops.get_boolean(param, "ntpdate_only", false)
+ ntpdate_only = param["ntpdate_only"]

required_package = "ntp"

@@ -384,16 +382,14 @@
elsif !Stage.initial
if !PackageSystem.CheckAndInstallPackages([required_package])
Report.Error(
- Builtins.sformat(
_(
- "Synchronization with NTP server is not possible\nwithout
package %1 installed."
- ),
- required_package
- )
+ "Synchronization with NTP server is not possible\nwithout
package #{required_package} installed."
+ )
)
end
end
- r = 0
+
+ ret = 0
if NetworkService.isNetworkRunning
#Only if network is running try to synchronize the ntp server
Popup.ShowFeedback("", _("Synchronizing with NTP server..."))
@@ -403,21 +399,16 @@
# -s: do set the system time
# -t 5: timeout of 5 seconds
# -l <file>: log to a file to not mess text mode installation
- r2 = Convert.to_integer(
- SCR.Execute(
- path(".target.bash"),
- Builtins.sformat(
- "/usr/sbin/sntp -l /var/log/YaST2/sntp.log -t 5 -s '%1'",
- String.Quote(ntp_server)
- )
- )
- )
- Builtins.y2milestone("'sntp %1' returned %2", ntp_server, r2)
+ ret = SCR.Execute(
+ path(".target.bash"),
+ "/usr/sbin/sntp -l /var/log/YaST2/sntp.log -t 5 -s
'#{String.Quote(ntp_server)}'"
+ )
+ Builtins.y2milestone("'sntp %1' returned %2", ntp_server, ret)
Popup.ClearFeedback
end


- return :ntpdate_failed if r != 0
+ return :ntpdate_failed if ret != 0

# User wants to more than running sntp (synchronize on boot)
WriteNtpSettings(ntp_servers, ntp_server, run_service) if !ntpdate_only
@@ -427,13 +418,12 @@

# ui = UI::UserInput
def ui_handle(ui)
- ui = deep_copy(ui)
redraw = false
if ui == :ntp_configure
rv = AskUser()
if rv == :invalid_hostname
handle_invalid_hostname(
- Convert.to_string(UI.QueryWidget(Id(:ntp_address), :Value))
+ UI.QueryWidget(Id(:ntp_address), :Value)
)
elsif rv == :next && !Stage.initial
# show the 'save' status after configuration
@@ -443,11 +433,11 @@
if ui == :ntp_now
rv = Write({ "ntpdate_only" => true })
if rv == :invalid_hostname
- handle_invalid_hostname(
- Convert.to_string(UI.QueryWidget(Id(:ntp_address), :Value))
- )
+ handle_invalid_hostname(UI.QueryWidget(Id(:ntp_address), :Value))
elsif rv == :success
redraw = true # update time widgets
+ else
+ Popup.Error(_("Connection to selected NTP server failed."))
end
end


continue with "q"...


Checked in at Tue Sep 2 15:57:22 CEST 2014 by ro

Remember to have fun...

--
To unsubscribe, e-mail: yast-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: yast-commit+help@xxxxxxxxxxxx

< Previous Next >
This Thread