Script 'mail_helper' called by ro Hello packager, This is just FYI. Your package was checked in in distribution "sle12" by autobuild-member: ro. Here comes the log... ---------------------------%<------------------------------ Hi, here is the log from ci_new_pac /mounts/work_src_done/SLE12/yast2-kdump -> sle12 ## BNC# 884997 : "autoyast install with kdump leaves kdump enabled when set to be disabled - SLES12 Beta9" (RESOLVED/FIXED) Changes: -------- --- /work/SRC/SUSE:SLE-12:GA/yast2-kdump/yast2-kdump.changes 2014-07-22 12:04:14.000000000 +0200 +++ /mounts/work_src_done/SLE12/yast2-kdump/yast2-kdump.changes 2014-08-07 16:49:23.000000000 +0200 @@ -1,0 +2,7 @@ +Thu Aug 7 14:44:03 CEST 2014 - schubi@suse.de + +- Autoyast: "add_crashkernel_param" will be set by using autoinst.xml + and will not be overwritten by proposal. (bnc#884997) +- 3.1.18 + +------------------------------------------------------------------- calling whatdependson for sle12-i586 Packages directly triggered for rebuild: - yast2-kdump - yast2-schema ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/SUSE:SLE-12:GA/yast2-kdump (Old) and /mounts/work_src_done/SLE12/yast2-kdump (BS:build ID:42389 MAIL:yast-commit@opensuse.org) (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-kdump", Maintainer is "yast-commit@opensuse.org" Old: ---- yast2-kdump-3.1.17.tar.bz2 New: ---- yast2-kdump-3.1.18.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-kdump.spec ++++++ --- /var/tmp/diff_new_pack.gs4txS/_old 2014-08-07 18:05:56.000000000 +0200 +++ /var/tmp/diff_new_pack.gs4txS/_new 2014-08-07 18:05:56.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-kdump -Version: 3.1.17 +Version: 3.1.18 Release: 0 Summary: Configuration of kdump License: GPL-2.0 ++++++ yast2-kdump-3.1.17.tar.bz2 -> yast2-kdump-3.1.18.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.17/package/yast2-kdump.changes new/yast2-kdump-3.1.18/package/yast2-kdump.changes --- old/yast2-kdump-3.1.17/package/yast2-kdump.changes 2014-07-21 18:00:55.000000000 +0200 +++ new/yast2-kdump-3.1.18/package/yast2-kdump.changes 2014-08-07 16:45:05.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Thu Aug 7 14:44:03 CEST 2014 - schubi@suse.de + +- Autoyast: "add_crashkernel_param" will be set by using autoinst.xml + and will not be overwritten by proposal. (bnc#884997) +- 3.1.18 + +------------------------------------------------------------------- Mon Jul 21 17:21:06 CEST 2014 - schubi@suse.de - Reading crashkernel parameter value only if it's set a non-empty. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.17/package/yast2-kdump.spec new/yast2-kdump-3.1.18/package/yast2-kdump.spec --- old/yast2-kdump-3.1.17/package/yast2-kdump.spec 2014-07-21 18:00:55.000000000 +0200 +++ new/yast2-kdump-3.1.18/package/yast2-kdump.spec 2014-08-07 16:45:05.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-kdump -Version: 3.1.17 +Version: 3.1.18 Release: 0 Summary: Configuration of kdump License: GPL-2.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.17/src/modules/Kdump.rb new/yast2-kdump-3.1.18/src/modules/Kdump.rb --- old/yast2-kdump-3.1.17/src/modules/Kdump.rb 2014-07-21 18:00:55.000000000 +0200 +++ new/yast2-kdump-3.1.18/src/modules/Kdump.rb 2014-08-07 16:45:05.000000000 +0200 @@ -749,17 +749,24 @@ @kdump_packages.concat KDUMP_PACKAGES end + def ProposeCrashkernelParam + ReadAvailableMemory() + # propose disable kdump if PC has less than 1024MB RAM + if @total_memory < 1024 + false + else + true + end + end + # Propose global variables once... # after that remember user settings def ProposeGlobalVars if !@propose_called - # propose disable kdump if PC has less than 1024MB RAM - if Ops.less_than(@total_memory, 1024) - @add_crashkernel_param = false - else - @add_crashkernel_param = true - end + # Autoyast: "add_crashkernel_param" will be set by using autoinst.xml + # (bnc#890719) + @add_crashkernel_param = ProposeCrashkernelParam() unless Mode.autoinst @crashkernel_param = false # added defualt settings @@ -914,11 +921,11 @@ settings = deep_copy(settings) Builtins.y2milestone("Importing settings for kdump") @crashkernel_param_value = Ops.get_string(settings, "crash_kernel", "") - @add_crashkernel_param = Ops.get_boolean( - settings, - "add_crash_kernel", - false - ) + if settings.has_key?("add_crash_kernel") + @add_crashkernel_param = settings["add_crash_kernel"] + else + @add_crashkernel_param = ProposeCrashkernelParam() + end result = true my_import_map = Ops.get_map(settings, "general", {}) Builtins.foreach(Map.Keys(@DEFAULT_CONFIG)) do |key| continue with "q"... Checked in at Thu Aug 7 18:06:05 CEST 2014 by ro Remember to have fun... -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org