See http://river.suse.de/job/yast-registration-master/128/changes
Changes:
[lslezak] use the status call and properly mark the already registered extensions
[lslezak] added test for Registration.activated_products
[lslezak] code review improvements
------------------------------------------
[...truncated 648 lines...]
[ 62s] + rake install DESTDIR=/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64
[ 63s] mkdir -p /home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/YaST2/
[ 63s] cp -r 'src/clients' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/YaST2/'
[ 63s] cp -r 'src/lib' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/YaST2/'
[ 63s] cp -r 'src/data' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/YaST2/'
[ 63s] mkdir -p /home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/lib/YaST2/
[ 63s] mkdir -p /home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/YaST2/schema/autoyast/rnc/
[ 63s] cp -r 'src/autoyast-rnc/registration.rnc' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/YaST2/schema/autoyast/rnc/'
[ 63s] mkdir -p /home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/var/adm/fillup-templates/
[ 63s] mkdir -p /home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/applications/YaST2/
[ 63s] cp -r 'src/desktop/customer_center.desktop' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/applications/YaST2/'
[ 63s] mkdir -p /home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/doc/packages/yast2-registration/
[ 63s] cp -r 'README.md' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/doc/packages/yast2-registration/'
[ 63s] cp -r 'COPYING' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/doc/packages/yast2-registration/'
[ 63s] cp -r 'CONTRIBUTING.md' '/home/abuild/rpmbuild/BUILDROOT/yast2-registration-3.1.82-1.x86_64/usr/share/doc/packages/yast2-registration/'
[ 63s] + /usr/lib/rpm/suse_update_desktop_file.sh customer_center
[ 63s] + /usr/lib/rpm/find-debuginfo.sh /home/abuild/rpmbuild/BUILD/yast2-registration-3.1.82
[ 63s] + /usr/lib/rpm/brp-compress
[ 63s] + /usr/lib/rpm/brp-suse
[ 63s] calling /usr/lib/rpm/brp-suse.d/brp-05-permissions
[ 63s] setting / to root:root 0755. (wrong owner/group abuild:abuild)
[ 63s] setting /usr/ to root:root 0755. (wrong owner/group abuild:abuild)
[ 63s] setting /var/adm/ to root:root 0755. (wrong owner/group abuild:abuild)
[ 63s] calling /usr/lib/rpm/brp-suse.d/brp-15-strip-debug
[ 63s] calling /usr/lib/rpm/brp-suse.d/brp-20-check-la
[ 63s] calling /usr/lib/rpm/brp-suse.d/brp-25-symlink
[ 63s] calling /usr/lib/rpm/brp-suse.d/brp-30-desktop
[ 64s] WARNING: '/usr/lib/rpm/brp-desktop.data/suse-screensavers.menu' does not exist
[ 64s] WARNING: '/usr/lib/rpm/brp-desktop.data/preferences-gnome.menu' does not exist
[ 64s] WARNING: '/usr/lib/rpm/brp-desktop.data/applications-kmenuedit.menu' does not exist
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-35-rpath
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-40-rootfs
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-45-tcl
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-50-check-python
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-55-boot-scripts
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-60-hook
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-65-lib64-linux
[ 64s] sf@suse.de: if you find problems with this script, drop me a note
[ 64s] calling /usr/lib/rpm/brp-suse.d/brp-72-extract-appdata
[ 64s] Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.t9ZJpA
[ 64s] + umask 022
[ 64s] + cd /home/abuild/rpmbuild/BUILD
[ 64s] + cd yast2-registration-3.1.82
[ 64s] + rake test:unit
[ 65s] rspec --color --format doc 'test/addon_spec.rb'
[ 66s]
[ 66s] Registration::Addon
[ 66s] .find_all
[ 66s] find all addons for current base product
[ 66s] find even dependend products
[ 66s] sets properly dependencies between addons
[ 66s] sets the registration status from status call
[ 66s] .selected
[ 66s] returns array with selected addons
[ 66s] .registered
[ 66s] returns array of already registered addons
[ 66s] #selected?
[ 66s] returns if addon is selected for installation
[ 66s] #selected
[ 66s] marks addon as selected
[ 66s] adds to list of selected only one
[ 66s] #unselected
[ 66s] marks addon as unselected
[ 66s] do nothing if addon is not selected
[ 66s] #registered?
[ 66s] returns if addon is already registered
[ 66s] #label
[ 66s] returns short name when the long name is nil
[ 66s] returns short name when the long name is empty
[ 66s] returns long name if it is present
[ 66s] #selectable?
[ 66s] returns false when the addon has been already registered
[ 66s] returns true when the addon has not been already registered
[ 66s] returns false when the parent is not selected or registered
[ 66s] returns true when the parent is selected
[ 66s] returns true when the parent is registered
[ 66s] returns false when any child is selected
[ 66s] returns false when the addon is not available
[ 66s] returns true when the addon is available
[ 66s] returns true when the addon availability is not set
[ 66s]
[ 66s] Finished in 0.02694 seconds
[ 66s] 24 examples, 0 failures
[ 66s] rspec --color --format doc 'test/suse_register_spec.rb'
[ 67s]
[ 67s] Registration::SuseRegister
[ 67s] .new
[ 67s] create new instance with /etc/suseRegister.conf from target root
[ 67s] #found?
[ 67s] returns false if file not found
[ 67s] returns false if file do not contain url key
[ 67s] returns true if file found and contain url key
[ 67s] #ncc?
[ 67s] returns false if file not found
[ 67s] returns false if file contain custom url
[ 67s] returns true if file contain ncc url
[ 67s] #stripped_url
[ 67s] return url without ending path for old registration protocol
[ 67s]
[ 67s] Finished in 0.00939 seconds
[ 67s] 8 examples, 0 failures
[ 67s] rspec --color --format doc 'test/registration_spec.rb'
[ 67s]
[ 67s] Registration::Registration
[ 67s] .register
[ 67s] registers the system using the provided registration code
[ 67s] .register_product
[ 67s] it should behave like add_product
[ 67s] adds the selected product and returns added zypp services
[ 67s] .upgrade_product
[ 67s] it should behave like add_product
[ 67s] adds the selected product and returns added zypp services
[ 67s] .activated_products
[ 67s] returns list of activated products
[ 67s]
[ 67s] Finished in 0.03159 seconds
[ 67s] 4 examples, 0 failures
[ 67s] rspec --color --format doc 'test/helpers_spec.rb'
[ 68s]
[ 68s] Registration::Helpers
[ 68s] .registration_url
[ 68s] at installation
[ 68s] no local registration server is announced via SLP
[ 68s] returns 'regurl' boot parameter from Linuxrc
[ 68s] returns nil when no custom URL is required in Linuxrc
[ 68s] no boot parameter is used and a SLP server is announced
[ 68s] returns the SLP server selected by user
[ 68s] returns nil when the SLP dialog is canceled
[ 68s] at installed system
[ 68s] ignores Linuxrc boot parameters
[ 68s] .service_url
[ 68s] converts a SLP service to plain URL
[ 68s] .service_description
[ 68s] creates a label with description and url
[ 68s] creates a label with url only when description is missing
[ 68s] .credentials_from_url
[ 68s] returns credentials parameter from URL
[ 68s] returns nil if the URL misses credentials parameter
[ 68s] raises URI::InvalidURIError when URL is invalid
[ 68s] .base_version
[ 68s] returns the version if build suffix is missing
[ 68s] returns base version without build suffix
[ 68s] .insecure_registration
[ 68s] outside installation/update
[ 68s] returns false and does not check boot parameters
[ 68s] at installation
[ 68s] returns false when reg_ssl_verify option is not used at boot commandline
[ 68s] returns false when reg_ssl_verify=1 boot option is used
[ 68s] returns true when reg_ssl_verify=0 boot option is used
[ 68s]
[ 68s] Finished in 0.04624 seconds
[ 68s] 17 examples, 0 failures
[ 68s] rspec --color --format doc 'test/sw_mgmt_spec.rb'
[ 68s]
[ 68s] Registration::SwMgmt
[ 68s] .service_repos
[ 68s] returns list of repositories belonging to a service
[ 68s] optionally returns only update repositories
[ 68s] .base_product_to_register
[ 68s] returns base product base version and release_type
[ 68s] .add_services
[ 68s] it creates a new service if the service does not exist yet
[ 68s] updates the existing service if the service already exists
[ 68s] .copy_old_credentials
[ 68s] does not fail when the old credentials are missing
[ 68s] copies old NCC credentials at upgrade
[ 68s] copies old SCC credentials at upgrade
[ 68s] .find_addon_updates
[ 68s] returns new available addons for installed addons
[ 68s]
[ 68s] Finished in 0.05583 seconds
[ 68s] 9 examples, 0 failures
[ 68s] rspec --color --format doc 'test/eula_downloader_spec.rb'
[ 69s]
[ 69s] Registration::EulaDownloader
[ 69s] .download
[ 69s] downloads the license with translations
[ 69s] it raises an exception when download fails
[ 69s]
[ 69s] Finished in 0.01269 seconds
[ 69s] 2 examples, 0 failures
[ 69s] rspec --color --format doc 'test/addon_selection_dialog_test.rb'
[ 70s]
[ 70s] Registration::UI::AddonSelectionDialog
[ 70s] .run
[ 70s] returns response from addon selection according to pressed button (FAILED - 1)
[ 70s] returns `:skip` if no addon is selected and user click next (FAILED - 2)
[ 70s] returns `:next` if some addons are selected and user click next (FAILED - 3)
[ 70s]
[ 70s] Failures:
[ 70s]
[ 70s] 1) Registration::UI::AddonSelectionDialog.run returns response from addon selection according to pressed button
[ 70s] Failure/Error: expect(subject.run(registration)).to eq :abort
[ 70s] Double received unexpected message :activated_products with (no args)
[ 70s] # ./src/lib/registration/addon.rb:31:in `find_all'
[ 70s] # ./src/lib/registration/ui/addon_selection_dialog.rb:30:in `initialize'
[ 70s] # ./src/lib/registration/ui/addon_selection_dialog.rb:24:in `new'
[ 70s] # ./src/lib/registration/ui/addon_selection_dialog.rb:24:in `run'
[ 70s] # ./test/addon_selection_dialog_test.rb:24:in `block (3 levels) in