Script 'mail_helper' called by ro Hello packager, This is just FYI. Your package was checked in in distribution "sle12" by autobuild-member: ro. Here comes the log... ---------------------------%<------------------------------ Hi, here is the log from ci_new_pac /mounts/work_src_done/SLE12/yast2-bootloader -> sle12 ## BNC# 873996 : "Failed to write kernel parameter for IPL and console device" (ASSIGNED/) ## BNC# 874010 : "Boot loader Settings offers a "VGA Mode"" (RESOLVED/FIXED) ## BNC# 873861 : "grub2-efi constructor on non-pc architectures" (ASSIGNED/) Changes: -------- --- /work/SRC/SUSE:SLE-12:GA/yast2-bootloader/yast2-bootloader.changes 2014-04-16 14:45:11.000000000 +0200 +++ /mounts/work_src_done/SLE12/yast2-bootloader/yast2-bootloader.changes 2014-04-17 14:12:51.000000000 +0200 @@ -1,0 +2,16 @@ +Thu Apr 17 11:18:31 UTC 2014 - jreidinger@suse.com + +- improve logging if setting kernel paramater failed to help with + bnc#873996 +- remove graphic adapter configuration on s390 (bnc#874010) +- 3.1.27 + +------------------------------------------------------------------- +Wed Apr 16 19:49:56 UTC 2014 - jreidinger@suse.com + +- allow switching to grub2 also on ppc +- Do not raise exception for grub2efi on non-pc architectures + (bnc#873861) +- 3.1.26 + +------------------------------------------------------------------- calling whatdependson for sle12-i586 Packages directly triggered for rebuild: - yast2-bootloader - yast2-kdump - yast2-product-creator - yast2-reipl - yast2-schema - yast2-vm ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/SUSE:SLE-12:GA/yast2-bootloader (Old) and /mounts/work_src_done/SLE12/yast2-bootloader (BS:build ID:36520 MAIL:yast-commit@opensuse.org) (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-bootloader", Maintainer is "yast-commit@opensuse.org" Old: ---- yast2-bootloader-3.1.25.tar.bz2 New: ---- yast2-bootloader-3.1.27.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-bootloader.spec ++++++ --- /var/tmp/diff_new_pack.QJxwfw/_old 2014-04-17 14:24:37.000000000 +0200 +++ /var/tmp/diff_new_pack.QJxwfw/_new 2014-04-17 14:24:37.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-bootloader -Version: 3.1.25 +Version: 3.1.27 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-bootloader-3.1.25.tar.bz2 -> yast2-bootloader-3.1.27.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-3.1.25/package/yast2-bootloader.changes new/yast2-bootloader-3.1.27/package/yast2-bootloader.changes --- old/yast2-bootloader-3.1.25/package/yast2-bootloader.changes 2014-04-16 14:20:16.000000000 +0200 +++ new/yast2-bootloader-3.1.27/package/yast2-bootloader.changes 2014-04-17 14:08:22.000000000 +0200 @@ -1,7 +1,23 @@ ------------------------------------------------------------------- +Thu Apr 17 11:18:31 UTC 2014 - jreidinger@suse.com + +- improve logging if setting kernel paramater failed to help with + bnc#873996 +- remove graphic adapter configuration on s390 (bnc#874010) +- 3.1.27 + +------------------------------------------------------------------- +Wed Apr 16 19:49:56 UTC 2014 - jreidinger@suse.com + +- allow switching to grub2 also on ppc +- Do not raise exception for grub2efi on non-pc architectures + (bnc#873861) +- 3.1.26 + +------------------------------------------------------------------- Wed Apr 16 12:11:53 UTC 2014 - jreidinger@suse.com -- fix crash on s390 due to missing loader widget(bnc#873911) +- fix crash on s390 due to missing loader widget(bnc#873911) - 3.1.25 ------------------------------------------------------------------- @@ -21,7 +37,7 @@ Tue Apr 15 08:33:29 UTC 2014 - mchang@suse.com - remove error if boot directory on xfs file system (bnc#864370) -- 3.1.22 +- 3.1.22 ------------------------------------------------------------------- Thu Apr 10 11:18:51 UTC 2014 - jreidinger@suse.com diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-3.1.25/package/yast2-bootloader.spec new/yast2-bootloader-3.1.27/package/yast2-bootloader.spec --- old/yast2-bootloader-3.1.25/package/yast2-bootloader.spec 2014-04-16 14:20:16.000000000 +0200 +++ new/yast2-bootloader-3.1.27/package/yast2-bootloader.spec 2014-04-17 14:08:22.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-bootloader -Version: 3.1.25 +Version: 3.1.27 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-3.1.25/src/include/bootloader/grub2/dialogs.rb new/yast2-bootloader-3.1.27/src/include/bootloader/grub2/dialogs.rb --- old/yast2-bootloader-3.1.25/src/include/bootloader/grub2/dialogs.rb 2014-04-16 14:20:16.000000000 +0200 +++ new/yast2-bootloader-3.1.27/src/include/bootloader/grub2/dialogs.rb 2014-04-17 14:08:22.000000000 +0200 @@ -68,6 +68,7 @@ def kernel_tab widgets = ["vgamode", "append", "append_failsafe", "console"] widgets.delete("console") if Arch.s390 # there is no console on s390 (bnc#868909) + widgets.delete("vgamode") if Arch.s390 # there is no graphic adapter on s390 (bnc#874010) { "id" => "kernel_tab", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-3.1.25/src/modules/BootCommon.rb new/yast2-bootloader-3.1.27/src/modules/BootCommon.rb --- old/yast2-bootloader-3.1.25/src/modules/BootCommon.rb 2014-04-16 14:20:17.000000000 +0200 +++ new/yast2-bootloader-3.1.27/src/modules/BootCommon.rb 2014-04-17 14:08:22.000000000 +0200 @@ -978,7 +978,7 @@ ) end end - if Arch.s390 + if Arch.s390 || Arch.ppc ret = ["grub2"] end # in order not to display it twice when "none" is selected diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-3.1.25/src/modules/BootGRUB2EFI.rb new/yast2-bootloader-3.1.27/src/modules/BootGRUB2EFI.rb --- old/yast2-bootloader-3.1.25/src/modules/BootGRUB2EFI.rb 2014-04-16 14:20:17.000000000 +0200 +++ new/yast2-bootloader-3.1.27/src/modules/BootGRUB2EFI.rb 2014-04-17 14:08:22.000000000 +0200 @@ -103,14 +103,15 @@ # Constructor def BootGRUB2EFI - if Arch.i386 + if Arch.i386 packages = ["grub2-i386-efi"] elsif Arch.x86_64 packages = ["grub2-x86_64-efi", "shim", "mokutil"] else - raise "no grub packages for EFI available for this architecture" + # do not raise exception as we call constructor everywhere even if it doesn't make sense + packages = [] end - + Ops.set( BootCommon.bootloader_attribs, "grub2-efi", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-3.1.25/src/modules/Bootloader.rb new/yast2-bootloader-3.1.27/src/modules/Bootloader.rb --- old/yast2-bootloader-3.1.25/src/modules/Bootloader.rb 2014-04-16 14:20:17.000000000 +0200 +++ new/yast2-bootloader-3.1.27/src/modules/Bootloader.rb 2014-04-17 14:08:22.000000000 +0200 @@ -1050,16 +1050,27 @@ elsif section == "LINUX_DEFAULT" section = getProposedDefaultSection end - return false if section == nil + if section.nil? + Builtins.y2error("section is nil, so kernel parameter cannot be set") + return false + end + sectnum = -1 index = -1 Builtins.foreach(BootCommon.sections) do |s| - index = Ops.add(index, 1) + index += 1 sectnum = index if Ops.get_string(s, "name", "") == section end - return false if sectnum == -1 - slabel = "" - return false if (key == "vga" || key == "root") && value == "true" + if sectnum == -1 + Builtins.y2error "Cannot find given section #{section} in sections #{BootCommon.sections.inspect}" + return false + end + + if (key == "vga" || key == "root") && value == "true" + Builtins.y2error "invalid values passed as kernel param #{key.inspect} => #{value.inspect}" + return false + end + if Builtins.contains(["root", "vga"], key) if value != "false" if key == "vga" @@ -1095,8 +1106,8 @@ Ops.set(BootCommon.sections, [sectnum, "__changed"], true) end BootCommon.changed = true - ret = true - ret + + return true end continue with "q"... Checked in at Thu Apr 17 14:24:58 CEST 2014 by ro Remember to have fun... -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org