Author: lslezak
Date: Fri Sep 23 12:12:26 2011
New Revision: 65963
URL: http://svn.opensuse.org/viewcvs/yast?rev=65963&view=rev
Log:
- code cleanup - removed obsoled code for handling selections
(replaced by patterns long time ago)
Modified:
trunk/product-creator/src/ProductCreator.ycp
trunk/product-creator/src/dialogs.ycp
Modified: trunk/product-creator/src/ProductCreator.ycp
URL: http://svn.opensuse.org/viewcvs/yast/trunk/product-creator/src/ProductCreator.ycp?rev=65963&r1=65962&r2=65963&view=diff
==============================================================================
--- trunk/product-creator/src/ProductCreator.ycp (original)
+++ trunk/product-creator/src/ProductCreator.ycp Fri Sep 23 12:12:26 2011
@@ -327,11 +327,7 @@
}
else
{
- boolean pkgret = Pkg::SetSelection( ProductCreator::Config["base"]:"" );
-
- foreach(string addon, ProductCreator::Config["addons"]:[], ``{
- Pkg::SetSelection( addon );
- });
+ y2warning("Unsupported software selection type: %1", ProductCreator::Config["type"]:`unknown);
}
if (size(ProductCreator::Config["packages"]:[] ) > 0)
@@ -2738,19 +2734,7 @@
}
else
{
- // Base Selection
- if (base!="")
- {
- Pkg::SetSelection(base);
- }
-
- // Addons
- if (size(addons) > 0 )
- {
- foreach(string s, addons, ``{
- Pkg::SetSelection(s);
- });
- }
+ y2warning("Unsupported software selection type: %1", ProductCreator::Config["type"]:`unknown);
}
packages = (list<string>) union(packages, post_packages);
Modified: trunk/product-creator/src/dialogs.ycp
URL: http://svn.opensuse.org/viewcvs/yast/trunk/product-creator/src/dialogs.ycp?rev=65963&r1=65962&r2=65963&view=diff
==============================================================================
--- trunk/product-creator/src/dialogs.ycp (original)
+++ trunk/product-creator/src/dialogs.ycp Fri Sep 23 12:12:26 2011
@@ -1131,11 +1131,7 @@
}
else
{
- boolean pkgret = Pkg::SetSelection( ProductCreator::Config["base"]:"" );
-
- foreach(string addon, ProductCreator::Config["addons"]:[], ``{
- Pkg::SetSelection( addon );
- });
+ y2warning("Unsupported software selection type: %1", ProductCreator::Config["type"]:`unknown);
}
if (size(ProductCreator::Config["packages"]:[] ) > 0)
@@ -1315,205 +1311,56 @@
`HVCenter(`Label(_("Reading package database..."))),
helptext, false, true);
- list<string> available_base_selections = Pkg::GetSelections( `available, "base" );
- y2milestone ("available_base_selections %1", available_base_selections);
-
- list<string> current_base_selections = Pkg::GetSelections( `selected, "base" );
- y2milestone ("current_base_selections %1", current_base_selections);
+ list<string> addons = patterns;
- boolean using_patterns = false;
+ // ensure that a langugage is selected
+ ProductCreator::CheckLanguage();
- // use patterns instead of selections
- if (size(available_base_selections) == 0)
+ if (size(addons) > 0 || ProductCreator::Config["base"]:"" != "")
{
- y2milestone("No selections, using patterns");
- using_patterns = true;
-
- list<string> addons = patterns;
-
- // ensure that a langugage is selected
- ProductCreator::CheckLanguage();
+ y2milestone("base pattern: %1, addons: %2", base_pattern, addons);
- if (size(addons) > 0 || ProductCreator::Config["base"]:"" != "")
+ // select the base pattern
+ if (base_pattern != "")
{
- y2milestone("base pattern: %1, addons: %2", base_pattern, addons);
-
- // select the base pattern
- if (base_pattern != "")
- {
- Pkg::ResolvableInstall(base_pattern, `pattern);
- }
+ Pkg::ResolvableInstall(base_pattern, `pattern);
+ }
- // select the addons
- foreach(string addon, addons,
- {
- Pkg::ResolvableInstall(addon, `pattern);
- });
+ // select the addons
+ foreach(string addon, addons,
+ {
+ Pkg::ResolvableInstall(addon, `pattern);
+ });
- // mark taboo packages
- ProductCreator::MarkTaboo(taboo);
+ // mark taboo packages
+ ProductCreator::MarkTaboo(taboo);
- Pkg::PkgSolve(true);
+ Pkg::PkgSolve(true);
- }
+ }
- // add extra packages
- if (size(packages) > 0)
+ // add extra packages
+ if (size(packages) > 0)
+ {
+ foreach(string p, packages,
{
- foreach(string p, packages,
- {
- InstallPackageOrProvider (p);
- });
- }
+ InstallPackageOrProvider (p);
+ });
+ }
- y2milestone("package selection mode: %1", mode);
+ y2milestone("package selection mode: %1", mode);
- if (mode == `packages)
- {
- ret = detailedSelection(nil);
- }
- else if (mode == `patterns)
- {
- ret = patternSelection();
- }
- else
- {
- y2error("Unknown mode parameter: %1", mode);
- }
+ if (mode == `packages)
+ {
+ ret = detailedSelection(nil);
+ }
+ else if (mode == `patterns)
+ {
+ ret = patternSelection();
}
else
{
- // save the current base selection
- string save_selection = current_base_selections[0]:"default";
-
- // Construct a box with radiobuttons for each software base configuration
- term baseconfs_box = `VBox();
-
- // sort available_base_selections by order
- // $[ "order" : [ "name", "summary" ], .... ]
-
- map