Author: mvidner Date: Mon May 12 13:42:37 2008 New Revision: 47447 URL: http://svn.opensuse.org/viewcvs/yast?rev=47447&view=rev Log: Report::{Long,}{Message,Warning,Error}: log the text before popping up a dialog so that eager bug reporters have the last message in the log (bnc#381594#c15). Modified: trunk/yast2/library/modules/Report.ycp trunk/yast2/package/yast2.changes Modified: trunk/yast2/library/modules/Report.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/yast2/library/modules/Report.ycp?rev=47447&r1=47446&r2=47447&view=diff ============================================================================== --- trunk/yast2/library/modules/Report.ycp (original) +++ trunk/yast2/library/modules/Report.ycp Mon May 12 13:42:37 2008 @@ -294,6 +294,11 @@ string yes_button_message, string no_button_message, symbol focus ) ``{ + if (log_yesno_messages) + { + y2milestone(1, "%1", message); + } + boolean ret = false; if (display_yesno_messages) { @@ -319,11 +324,6 @@ } } - if (log_yesno_messages) - { - y2milestone(1, "%1", message); - } - yesno_messages = add(yesno_messages, message); return ret; } @@ -334,6 +334,11 @@ * @return void */ global define void Message(string message_string) ``{ + if (log_messages) + { + y2milestone(1, "%1", message_string); + } + if (display_messages) { if (timeout_messages > 0) @@ -346,11 +351,6 @@ } } - if (log_messages) - { - y2milestone(1, "%1", message_string); - } - messages = add(messages, message_string); } @@ -360,6 +360,11 @@ * @return void */ global define void LongMessage(string message_string) ``{ + if (log_messages) + { + y2milestone(1, "%1", message_string); + } + if (display_messages) { if (timeout_messages > 0) @@ -372,11 +377,6 @@ } } - if (log_messages) - { - y2milestone(1, "%1", message_string); - } - messages = add(messages, message_string); } @@ -387,6 +387,11 @@ * @return void */ global define void ShowText(string headline_string, string message_string) ``{ + if (log_messages) + { + y2milestone(1, "%1", message_string); + } + if (display_errors) { if (timeout_errors > 0) @@ -400,11 +405,6 @@ } } - if (log_messages) - { - y2milestone(1, "%1", message_string); - } - messages = add(messages, message_string); } @@ -414,6 +414,11 @@ * @return void */ global define void Warning(string warning_string) ``{ + if (log_warnings) + { + y2warning(1, "%1", warning_string); + } + if (display_warnings) { if (timeout_warnings > 0) @@ -426,11 +431,6 @@ } } - if (log_warnings) - { - y2warning(1, "%1", warning_string); - } - warnings = add(warnings, warning_string); } @@ -440,6 +440,11 @@ * @return void */ global define void LongWarning(string warning_string) ``{ + if (log_warnings) + { + y2warning(1, "%1", warning_string); + } + if (display_warnings) { if (timeout_warnings > 0) @@ -452,11 +457,6 @@ } } - if (log_warnings) - { - y2warning(1, "%1", warning_string); - } - warnings = add(warnings, warning_string); } @@ -467,6 +467,11 @@ * @return void */ global define void Error(string error_string) ``{ + if (log_errors) + { + y2error(1, "%1", error_string); + } + if (display_errors) { if (timeout_errors > 0) @@ -479,11 +484,6 @@ } } - if (log_errors) - { - y2error(1, "%1", error_string); - } - errors = add(errors, error_string); } @@ -493,6 +493,11 @@ * @return void */ global define void LongError(string error_string) ``{ + if (log_errors) + { + y2error(1, "%1", error_string); + } + if (display_errors) { if (timeout_errors > 0) @@ -505,11 +510,6 @@ } } - if (log_errors) - { - y2error(1, "%1", error_string); - } - errors = add(errors, error_string); } Modified: trunk/yast2/package/yast2.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/yast2/package/yast2.changes?rev=47447&r1=47446&r2=47447&view=diff ============================================================================== --- trunk/yast2/package/yast2.changes (original) +++ trunk/yast2/package/yast2.changes Mon May 12 13:42:37 2008 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Mon May 12 13:42:11 CEST 2008 - mvidner@suse.cz + +- Report::{Long,}{Message,Warning,Error}: log the text before popping + up a dialog so that eager bug reporters have the last message in the + log (bnc#381594#c15). + +------------------------------------------------------------------- Fri May 09 12:19:58 CEST 2008 - aschnell@suse.de - Fixed keyboard on PPC during installation (bnc #387567) -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org