Egbert Eich wrote:
Hans Ulrich Niedermann writes:
I have recently taken a look at the lists of supported devices in radeonhd. As far as I can tell, we have four of those:
1. The wiki page: http://wiki.x.org/wiki/radeonhd 2. In the radeonhd source tree: 2a. src/rhd.h (enum RHD_CHIPSETS) 2b. src/rhd_id.c (void RHDIdentify()) 2c. man/radeonhd.man (section SUPPORTED HARDWARE)
Specifically, rhd_id.c has one more name for RV670 than radeonhd.man, and:
rhd.h rhd_id.c radeonhd.man M86 yes no yes RS780 yes yes no RV770 yes yes no RS740 yes no no
I can easily submit a patch for radeonhd.man bringing it in sync with rhd_id.c, but what about M86 and RS740?
I've also got a patch (see below) which attempts to bring all of them in sync.
The attached patch does some bit shifting in rhd_i2c.c, but I cannot quite make the connection to the list of supported chipsets.
RS740 should be identical to RS690 (although we have not seen any, yet). We have not had a chance to test an M86 but it should be a mobile RV635. We haven't seen one but the patch will enable it (People seemed to have added these ids to their code already and had reported problems, however to track them better it's good to have support for them added to the master in our git repo. Ndim, please feel free to commit your fixes. We should definitely have your fix to autogenerate the man page information and keep it in sync (we may have to fix the information strings in rhd_id.c, though).
OK, I'll just push my man page updating patch as it is, and let's figure out how to fix the corner cases later. I guess the attached patch might actually add support RS740/RS690, so adding it in a later commit together with an update to rhd_id.c will make sense? -- Hans Ulrich Niedermann