http://bugs.freedesktop.org/show_bug.cgi?id=13831 Summary: Misc. code cleanups suggested by Paulo de Andrade Product: xorg Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/radeonhd AssignedTo: lverhaegen@suse.de ReportedBy: awilliamson@mandriva.com QAContact: xorg-team@lists.x.org CC: pcpa@mandriva.com.br Hi, guys. Trying to build radeonhd 1.1.0 on Mandriva I ran into a build error. This resulted in a rapid stream of suggestions for code cleanups by pcpa (our resident X code guy), about 25% of which I understand at all. :) I am therefore doing an unedited copy / paste dump on to you guys on the hope that you understand 'em better than I do! Thanks. <pcpa> AdamW: I was going to ask you what error messages, but just tried to compile it. Just patch it to not include "xf86_ansic.h". It is some conflicting defintions with glibc headers and xf86libcwrapper, but libcwrapper isn't supported anymore in upstream. <pcpa> AdamW: This basically will cause libc calls to not be wrapped. It has been broken for very long also, but just commenting it is enough to fix the problem. <pcpa> AdamW: you also need change calls to xf86snprintf to snprintf and xf86strdup to strdup (those were wrappers, and should not be called directly...) <pcpa> yes, in xorg git upstream libcwrapper has been removed almost one month ago. You can submit a bug report I think If any of this is unclear, please ask pcpa about it. I'll try and CC him on this bug. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ xorg-team mailing list xorg-team@lists.x.org http://lists.x.org/mailman/listinfo/xorg-team -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org