Jan, On Thu, 2017-06-29 at 13:44 +0200, jan matejek wrote:
fellow pythonistas,
i'd like to propose a new review rule: do not accept new python modules into Factory that are not either singlespec or explicitly versioned.
So "python2-foo" is fine, "python3-foo" is fine, "python-foo" which is not singlespec is rejected.
sounds reasonable to me - but as this seems to be something a bot can check upon, I would rather see the bot take care of that: If it's cheap / easy to check : https://github.com/openSUSE/osc-plugin-factory/blob/master/source-check er.pl if more complex or time consuming, then we should probably rather add it to repo-checker - which already spends quite some time on many submissions. Reason why a bot: the bot is just less 'stressed' any makes less mistakes for such obvious things. And people can discuss with the bot as much as they want.
For apps that have python as a requirement, do not accept anything that requires "python", and look hard on apps that require "python2". (they should require python3 unless the app actually doesn't work with it)
That one is probably harder to have in a bot, so will have to be cast off to the review team.
This would apply to *new* packages. Anyone opposed?
I'd like to apply to existing packages too... as in, if you touch a thing that requires python, also make sure that it is versioned. But perhaps this is not a reason for rejection, more like, leave a comment "can you please also do this"?
imho, this kind of change should be implemented in rpmlint checks first; so that we can get an overview of how much break we curretnly have (remember, we have http://rpmlint.opensuse.org where we casn filter on them) Cheers, Dominique