On Thu, 26 Nov 2015 13:00:19 +0100 (CET)
Jan Engelhardt
On Thursday 2015-11-26 12:04, Petr Tesarik wrote:
However, these legacy distributions contain ancient versions of GNU autotools and friends, so autoreconf does not work properly when building for those targets (missing features, bugs). The scripts included in the upstream tarball are definitely better. Is it OK if I do _not_ run autoreconf in the specfile?
It is not only OK, but even preferred not to run autoreconf, as long as there is no problem with the included configure script.
I see. I probably shouldn't have accepted submitrequest 325452 back then (sorry Jan!). I'm going to remove the autoreconf stuff completely (including the libtool BuildRequires that prevents building on SLE10).
Hm? 325452 is impertinent to the question; 325452 does one thing: to create configure if it did not exist yet -- without a configure script present, %configure would not ever run. And if a configure script is already present, the check does no harm. In other words, 325452 is justified to stay, I think.
Well, yes and no. This submit request started it all: It also added "BuildRequires: libtool >= 2", because (presumably) autoreconf failed otherwise. That part made the package unresolvable in SLE10 (which only ships libtool-1.5). Anyway, while trying to make it build again, I wondered if there was any policy on this topic and I found this macro: https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#.25suse_up... I checked a few packages that use autoconf, but none of them was using this macro, but some of them used autoreconf. At this point I was unsure if I'm supposed to use that macro (as suggested by the above-mentioned page), run it unconditionally (like some packages do), run it only on recent distros (like some other packages do), or ignore it and just run %configure (like most packages do). For now, I have completely removed autoreconf from my specfile. Works fine on a few dozen build targets... Petr T -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org