On Friday 16 December 2011, Stephan Kulow wrote:
On 16.12.2011 11:14, Adrian Schröter wrote:
Since I really like to keep my stuff (OBS packages) also working for this old (well, SLE 11 is actually still the most up2date enterprise distro of us) rpms, I like to request to drop the Group removeing for now.
Or to add %if %suse_version around it so it is only active on old distro.
BAH, that's the worst option of all.
Otherwise people will find workarounds to not use the formater at all anymore ...
BTW how does that service works exactly? For example this one in server:http/libev https://build.opensuse.org/package/rdiff?linkrev=base&package=libev&project=server%3Ahttp&rev=7 Was it committed manually or automatically? Will it happens again after now being fixed again in r11?
I wonder if it wouldn't make more sense to have the build script run a spec file patcher - either distribution specific or in general - after all the duplicated group does not really harm in the spec file.
But with this logic we will keep support for old rpms in our factory spec files forever. So this spec file patcher could also add a buildroot or even a default %clean section - right before building without us having to carry those forever in the sources.
The idea looks good but IMO it would be quite confusing for spare time packagers if such patcher applies hidden magic differently for different distros. I think generally any code formatters are nice but should be only used seldom as single shots and not automatically again and again. For me a clean commit history with mostly significant diffs is more important than having every white space corrected but endless confusing commits even without or with nonsense commit messages like the libev example above: https://build.opensuse.org/package/revisions?package=libev&project=server%3Ahttp BTW I'd like some mechanism to be noticed about such breakage at least. If a commit breaks the build for a target which worked before then the one who did that commit should get an email about requiring him to fix that again. If he does not fix that within one day (or if he does not confirm somehow that that breakage was wanted) then his patch should get reverted automatically. cu, Rudi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org