On 04/12/2010 11:09 AM, Dave Plater wrote:
On 04/12/2010 11:02 AM, Takashi Iwai wrote:
At Mon, 12 Apr 2010 10:58:05 +0200, I wrote:
At Mon, 12 Apr 2010 10:49:43 +0200, Dave Plater wrote:
On 04/12/2010 10:32 AM, Takashi Iwai wrote:
At Mon, 12 Apr 2010 10:19:11 +0200, Dave Plater wrote:
On 04/12/2010 09:54 AM, Takashi Iwai wrote:
> At Sun, 11 Apr 2010 08:36:58 +0200, > Dave Plater wrote: > > > >> Hi, I'm updating multimedia:apps solfege and the new version produces a >> lot of .pyc files on make install which contain text which refers to the >> path that the file was installed in :- >> /usr/src/packages/BUILDROOT/solfege-3.16.1-1.x86_64//usr/share/solfege/solfege/ >> This causes lot's of rpmlint errors ie. ;- >> solfege.x86_64: E: file-contains-buildroot (Badness: 10000) >> /usr/share/solfege/solfege/cfg.pyc >> I understand these files to be compiled python but being a complete >> novice with python I don't know what to do with them. >> >> >> > You'd need to refresh the patch solfege-compile-all-fix.diff in m:l or > FACTORY solfege package for Makefile of solfege-3.16.1... > > > Takashi > > > I removed solfege-compile-all-fix.diff because all the changes in it where already in Makefile.in.
It's obviously not :)
I've tested solfege a bit with the pyc files deleted and it seems to work, if they do cause a bug it's a simple matter to not delete them on build.
This can be controlled even via passing nopycompile=YES at make installation time.
Takashi
I'll try the patch but a simple "find $RPM_BUILD_ROOT%{_datadir}/%{name}/%{name}/ -name *pyc -delete" in the spec file also does the job.
But not the same job.
To clarify: the patch fixes the bug in Makefile for wrong paths in *.pyc with $(DESTDIR).
Deleting *.pyc is a workaround but it slows down the program start up, too, as darix mentioned.
Takashi
I used rpmbuild -bi on solfege with the patch applied but it still builds the offending .pyc files but on examination they only contain installed paths not build root ones, I'll test it when the build service api server works again. Thanks Dave P
Patch works :-) thanks. Regards Dave P -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org