On Wed, May 15, 2013 at 05:58:58PM +0400, Денис Купляков wrote:
I have done more investigation using debugfs commands, it seems for me that 0x11 command (set_brightness) works very unusual. There is a comment in code about quirk workaround for some notebook models. It says that if you will set brightness to/from 0 all work like real "set" function. But it is false for me, in spite of that my notebook have stepping mode. I'm sending you attachment with console output and some comments from me.
I propose to rewrite set_brightness to something like this:
while (don't have need brightness && number_of_iterations <= MAX_BRIGHTNESS) { change brightness }
if (don't have need brightness) { some error found }
It will work good for all notebook models (step-mode with 0-set, step-mode(like me) and set-mode) and it will be possible to remove stepping quirk workaround at all. Do you know other behaviors for set command?
Best regards, Denis Kuplyakov.
I don't know the behaviors at all, sorry. I suggest contacting the upstream maintainer of the driver about this, as they are the one that can fix this the best for you. The name of the maintainer and email address is in the MAINTAINERS file in the kernel source tree. Hope this helps, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org