Mailinglist Archive: opensuse-kernel (80 mails)

< Previous Next >
[opensuse-kernel] Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
Andrei Warkentin wrote:
1 is a power of two, therefore rounddown_pow_of_two(1) should return 1. It
does in case the argument is a variable but in case it's a constant it
behaves wrong and returns 0. Probably nobody ever did it so this was never
noticed, however net/drivers/vmxnet3 with latest GCC does and breaks on
unicpu systems.

Obviously correct.

Reviewed-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
< Previous Next >