Feature changed by: Adrian Schröter (adrianSuSE) Feature #308991, revision 4 Title: fix diff for accepted requests Buildservice: Evaluation Priority Requester: Important Projectmanager: Important Requested by: Ruediger Oertel (oertel) Description: the hermes message shows a link like https://build.opensuse.org/request/diff/32196 that is already broken by the time you get the notice since the source package is usually deleted already. Discussion: #1: Adrian Schröter (adriansuse) (2010-02-11 16:38:41) The api is getting the revision numbers of all target packages on processing the request. It could send them to hermes, but so far we do not have infrastructure to do an hermes call in the api. Klaas, can you provide a stub to send hermes notifications from the api ? #2: Thomas Schmidt (digitaltomm) (2010-02-11 17:38:27) Isn't the problem here, that the source package is already removed? Is there a way to get a diff to an already removed package? Another problem I think is, that there will be no diff to the target when the request is already accepted, so we need to diff to a special revision. + #3: Adrian Schröter (adriansuse) (2010-02-11 17:54:52) (reply to #2) + yes, you need to create the diff of the target package for revision X. + No need to use the source package at all. + The api gets the revision number from backend when executing the + request. So it could report it to hermes. + (one could also lookup the request via the request id in the package + history, but that is more resource intensive). -- openSUSE Feature: https://features.opensuse.org/308991