Hi Larry Am 28.07.19 um 19:43 schrieb Larry Finger:
For Tumbleweed users, vboxvideo has been part of every kernel for several cycles without any complaints from users. As Stephan notes, it refuses to load. Although vboxguest is also a part of the kernel, we still need to build it as the kernel's version has different symbols, thus vboxsf requires the out-of-kernel version. Adding vboxguest and vboxsf to a single kmp package would add only a few MB to the download and total storage required, thus it should not be a system breaker. In fact, Oracle delivers both kinds of modules and everything else in a single RPM.
It's only ~850kB per kmp package, so 1.7MB both together. Not worth bothering IMHO.
I would argue that the size and complexity of the virtualbox spec argues against having separate kmod specs. The changes required to combine the two kinds of modules is trivial. In addition, checking that section of the spec has resulted in the finding of several if statements that were wrong, thus we are getting some bug fixes "for free". Keeping a single package also preserves the existing update procedures.
Michal's changes to the macros may fix the problem, and changing the virtualbox spec may not help, but I am willing to go ahead with changing the spec. We have also been living with some unintended conflicts that should be fixed.
I did unify the kmp in home:seife:testing/virtualbox and the provides and requires (ksym...) look good, so maybe you can take it just from there. -- Stefan Seyfried "For a successful technology, reality must take precedence over public relations, for nature cannot be fooled." -- Richard Feynman -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org