On Thu, Nov 29, Wolfgang Rosenauer wrote:
Am 29.11.18 um 17:29 schrieb Thorsten Kukuk:
3. if the package was already installing the cron job directly with installation is it expected that the corresponding service and timer is requested to be added to the defaults or should it stay with the user (who probably does not expect that he needs to do something; see
Depends on the job. If the cron job did always run because it is required, then you should also enable the timer by default. If the cron job only run because it was easier, but does not do anything before the customer does modify/enable something, you should document that the user now has to enable the timer, too.
Thanks for the answers. So the cron job before was running but it only did something useful if something was configured. Therefore I _guess_ a manual enablement would be the right thing. But then there is the update case where there is a configuration but the upgrade would kill the cronjob and not enable the timer. Is there a way to do it right in this case?
In the upgrade case you need to read the config and enable the timer if needed. But that's difficult, as enabling the timer does not necessary start it. You could look at other packages like snapper or btrfsmaintenance, who did something similar already in the past. That's why I wrote: get the update case right in Factory first ;) Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org