Am 18.05.2017 um 16:42 schrieb Jan Engelhardt:
On Thursday 2017-05-18 16:38, Andreas Färber wrote:
Am 18.05.2017 um 14:05 schrieb Jan Engelhardt:
I just felt like hacking up, and now sharing, a script to gauge where there is overly much advertisement language in the descriptions of openSUSE TW packages.
I feel it would me more helpful to have some easily accessible guidelines with good vs. bad examples for new packages being added...
https://en.opensuse.org/openSUSE:Package_description_guidelines ?
Yes, like that (and I actually recall reading it at some point). I meant something different than just _having_ a Wiki page though. GitHub I believe has a feature that when someone does a pull request it will show them a contributing.md file from that repository with any specific requirements like Signed-off-by or Coding Style before it's submitted. In absence of such a feature for OBS submissions (there's just the small grey box with target project, package name and summary) the first time a new contributor learns about its existence will be when you as reviewer complain about it and take the time to give them such a link (which I don't think you do, you rather do SRs fixing things up yourself ;)). So having some way for OBS to deliver a checklist for new packages (description, groups, target project, ...) might be a good idea. I.e., fix the problem at its source where new errors are being introduced, rather than only running scripts after the fact.
rpmlint forces people to write or copy BS simply because minimal no-BS descriptions result in length warnings.
rpmlint is practically useless - people complete ignore it, even for trivial things like "summary must not end in dot".
Not entirely useless, but its output is too well hidden on the separate tab and showing only one architecture at a time there. Some more prominent, colored display of "n rpmlint warnings" might be sufficient to make people aware. Maybe an rpmlint rule or a review bot for certain buzzwords might work? Just as with spell checkers that would surely run into false positives. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org