Hello Martin, On Aug 26 15:41 Martin Wilck wrote (excerpt):
On Fri, 2016-08-26 at 15:25 +0200, Johannes Meixner wrote:
I like it when RPM changelog entries are explanatory so that even relatively unexperienced users can understand what an issue is about (regardless whether or not others may prefer terse RPM changelog entries).
Hmm, I didn't quite grok this when you first wrote it. I just committed a new version to my branch with a terse commit message:
- Fixed device communication/detection problems with mdns/Bonjour see https://bugs.launchpad.net/hplip/+bug/1616861
Everything is perfectly o.k. because https://en.opensuse.org/openSUSE:How_to_contribute_to_the_Printing_project reads (excerpts): --------------------------------------------------------------------- For each change describe the change and provide a reason why the change was done in the RPM changelog. For example describe what does not work without the change or what additional functionality is provided by the change. Such a reason could be an URL to an openSUSE bug report (e.g. boo#1234) or an URL to an upstream issue report. When there is no URL you need to explain the change and its reason in a way so that others who do not yet know about it can understand what the issue is about. ... For example "Foo-driver version upgrade to 1.2.3" alone is insufficient because it tells only "what" but not "why". In contrast "Bugfix for boo#1234 (upstream issue http://www.example.org/issue4567)" could be perfectly sufficient provided at least one of the openSUSE bug report and the upstream issue report is public accessible and tells about "what" and "why". --------------------------------------------------------------------- => Just resubmit & accept. FYI: What I mean with "terse changelog entry" would be something like - Fix mdns that we had at least in the past more often than not. Kind Regards Johannes Meixner -- SUSE LINUX GmbH - GF: Felix Imendoerffer, Jane Smithard, Graham Norton - HRB 21284 (AG Nuernberg)