On Thursday, July 7, 2016 11:19:40 AM WEST Ancor Gonzalez Sosa wrote: Hi Joaquin,
First of all, thanks for the effort. The module is looking fine so far. Good work!
Now, the "not so nice" part. :-)
I tested the module and found some usability quirks. I would be interested in other people opinion:
* It was kind of surprising to me that selecting a choice or setting the alternative to automatic immediately closed the modal dialog.
For me it was expected. But I also expected some kind the "Set choice" to be selected by default (so I could just hit "enter" to select the option).
* Initial focus on "search" is kind of strange in ncurses (although having a bad initial focus on ncurses is almost a YaST trend :-) ).
I don't have a strong opinion about that. But yes, I would expect the focus in the list.
* After changing an alternative (and thus closing the modal dialog) the focus in the list of alternatives is again in the first item of the list. I expect that kind of listing reloading in a web page, but it feels weird for a desktop application.
+1
* Cancel should alert that changes will be lost.
+1
* The header of the choices table reads "alternative" instead of "choice".
* I expected that selecting a choice and pressing enter (in ncurses) our double clicking on it (in Qt) would set that choice, but I need to use the "Set choice" button.
+1 (as I said before). For me pressing enter in ncurses should set the choice and close the dialog.
As said, just my view. I would like to know what other people has to say.
Cheers.
On the other hand, nice work! Regards, Imo -- Imobach González Sosa YaST team at SUSE LINUX GmbH