denisart benjamin2
The correct stuff for python is rm -rf "{buildroot}%{python_sitelib}"
Thanks.
But I think it is not necessary with etckeeper.
2014-07-09 9:05 GMT+09:00 Christian Boltz
Am Mittwoch, 9. Juli 2014 schrieb 1xx:
- removed "Requires: git". users can select VCS.
Too bad that rpm doesn't support "or" in the Requires: tag ;-)
Nevertheless, you should add a "Recommends: git" - that's the most likely choice nowadays.
Thanks. I will rewrite so etckeeper.spec.
Just a little detail - I assume you mean integration with zypp (libzypp, zypper, YaST), right? A packagename like etckeeper-zypp-integration might be a better choice ;-)
I think that etckeeper-zypp-plugin is better. Because already snapper-zypp-plugin exists.
After reading the spec, I see that you package a yum plugin if suse_version is not set. The funny thing is that yum is also available for openSUSE [1], so you should also provide a package etckeeper-yum- integration for openSUSE ;-)
Hurm... The upstream can choose with both yum and ZYpp. But both can not choose. If we want it, we must make a big patch. I want time to think it. I think that better package name is etckeeper-yum-plugin. Thanks Christian, Denisart, and all!
[1] zypper in yum # and probably some subpackages, see zypper se yum (I just noticed it's available, but never used it.)
--
1xx