Hi Cristian, Please do not hide other changes in your patches. Here you snuck in -fvisibility-inlines-hidden, in another package you removed -pedantic etc. Ciao, Marcus On Thu, May 10, 2012 at 02:34:57PM +0200, h_root wrote:
Hello community,
here is the log from the commit of package taglib for openSUSE:Factory checked in at 2012-05-10 14:34:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/taglib (Old) and /work/SRC/openSUSE:Factory/.taglib.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "taglib", Maintainer is "VDziewiecki@suse.com"
Changes: -------- --- /work/SRC/openSUSE:Factory/taglib/taglib.changes 2012-03-09 21:28:46.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.taglib.new/taglib.changes 2012-05-10 14:34:52.000000000 +0200 @@ -1,0 +2,10 @@ +Thu May 10 01:51:54 UTC 2012 - crrodriguez@opensuse.org + +- Also, define GNU_SOURCE + +------------------------------------------------------------------- +Thu May 10 01:11:38 UTC 2012 - crrodriguez@opensuse.org + +- No dont use -ansi gcc flag. + +-------------------------------------------------------------------
New: ---- taglib-noansiflags.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences: ------------------ ++++++ taglib.spec ++++++ --- /var/tmp/diff_new_pack.HZSPjj/_old 2012-05-10 14:34:56.000000000 +0200 +++ /var/tmp/diff_new_pack.HZSPjj/_new 2012-05-10 14:34:56.000000000 +0200 @@ -28,6 +28,7 @@ Source1: %{name}.desktop Source100: baselibs.conf Patch1: taglib-1.6-ds-rusxmms.patch +Patch2: taglib-noansiflags.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: cmake BuildRequires: doxygen @@ -96,12 +97,12 @@ %prep %setup -q %patch1 -p1 - +%patch2 %build mkdir build cd build -export CXXFLAGS="%{optflags}" -export CFLAGS="%{optflags}" +export CXXFLAGS="%{optflags} -D_GNU_SOURCE" +export CFLAGS="%{optflags} -D_GNU_SOURCE" _libsuffix=$(echo %{_lib} | cut -b4-) cmake -DCMAKE_INSTALL_PREFIX=%{_prefix} -DBUILD_TESTS:BOOL=ON -DLIB_SUFFIX=$_libsuffix -DWITH_ASF:BOOL=ON -DWITH_MP4:BOOL=ON .. make %{?_smp_mflags} VERBOSE=1
++++++ taglib-noansiflags.patch ++++++ --- CMakeLists.txt.orig +++ CMakeLists.txt @@ -24,8 +24,8 @@ set(INCLUDE_INSTALL_DIR "${CMAKE_IN
if (CMAKE_COMPILER_IS_GNUCXX) if (CMAKE_SYSTEM_NAME MATCHES Linux) - set ( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-long-long -ansi -Wundef -Wcast-align -Werror-implicit-function-declaration -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security -Wmissing-format-attribute -fno-common") - set ( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security -fno-check-new -fno-common") + set ( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-long-long -Wundef -Wcast-align -Werror-implicit-function-declaration -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security -Wmissing-format-attribute -fno-common") + set ( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility-inlines-hidden -Wnon-virtual-dtor -Wno-long-long -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security -fno-check-new -fno-common") endif (CMAKE_SYSTEM_NAME MATCHES Linux) endif (CMAKE_COMPILER_IS_GNUCXX) if(MSVC) -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org
-- Working, but not speaking, for the following german company: SUSE LINUX Products GmbH, HRB 16746 (AG Nuernberg) Geschaeftsfuehrer: Jeff Hawn, Jennifer Guild, Felix Imendoerffer -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org