On 5/5/2011 10:13 AM, Michal Vyskocil wrote:
On Tue, May 03, 2011 at 04:12:32PM +0200, Stephan Kulow wrote:
Hi,
After a series of broken packages because of _service files I would like to forbid them in openSUSE:Factory.
So far I've seen the use of _service files in factory as an experiment (I happily joined), but I see this experiment as failed.
What I would like to propose is: - ban recompress, download and tarscm as _services (everything else should have been banned before) - instead we verify the Source urls and make packages that have invalid URLs "broken", so you can't SR them to factory.
This means: the Source URL is now an important thing to change and no longer a bit rotting comment and we stop recompressing tars - this was a proposal from Adrian a while ago without much objection.
+1 for not recompressing - in adtion please remove the ugly source is not bzipped - I'd say having the **same** source file is more important, than saving few bytes.
I also highly disagree with the idea of re-packaging source archives in other formats. It's sort of tempting to think it's safe and doesn't count as modifying the data. But for example there are some sources that come from upstream as .zip from primarily Windows or Mac developers and have all manner of file/directory name oddness. I have seen some of these re-packaged into more normal looking archives, not only changing from .zip to .tar.gz, but changing the directory structure, removing capitalization, changing the root directory name to what the %setup macro expects, even removing dos line-endings from text files (instead of doing it via commands in the spec). This results in: * The rest of the spec defines how to unpack and build that specially crafted archive, NOT the original. The info about the original is lost. * There is no way to know that nothing _else_ was changed to suit the repackagers aesthetics. * It requires the same manual, work to be done over again the same way at the next update. * Some of the steps needed to create the package and build the source are not documented within the spec or patches. They were done manually by someone and then the spec just starts off expecting this to already have been done. This all made me decide at least for myself that there really is no valid place to draw the line as to what is ok to change and what should not be changed. The simplest, and the only trustworthy approach is just never change anything. Do all such work within the spec and/or via patches. Even an uncompressed tar is ok, since the encapsulating cpio in the src rpm is compressed anyways. -- bkw -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org