Hello community,
here is the log from the commit of package epiphany for openSUSE:Factory checked in at 2019-08-05 10:35:49
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/epiphany (Old)
and /work/SRC/openSUSE:Factory/.epiphany.new.4126 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "epiphany"
Mon Aug 5 10:35:49 2019 rev:166 rq:720104 version:3.32.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/epiphany/epiphany.changes 2019-06-24 21:53:30.248112547 +0200
+++ /work/SRC/openSUSE:Factory/.epiphany.new.4126/epiphany.changes 2019-08-05 10:36:05.331336549 +0200
@@ -1,0 +2,10 @@
+Tue Jul 30 21:36:27 UTC 2019 - Bjørn Lie
+
+- Update to version 3.32.4:
+ + Hide certain context menu entries from nondownloadable videos.
+ + Fix crash when entering application manager.
+ + Fix JS type error when loading forms without action attribute.
+ + Fix miscellaneous programming errors.
+- Drop epiphany-web-app-utils_Fix-crash.patch: Fixed upstream.
+
+-------------------------------------------------------------------
Old:
----
epiphany-3.32.3.tar.xz
epiphany-web-app-utils_Fix-crash.patch
New:
----
epiphany-3.32.4.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ epiphany.spec ++++++
--- /var/tmp/diff_new_pack.PFFpLN/_old 2019-08-05 10:36:06.743336387 +0200
+++ /var/tmp/diff_new_pack.PFFpLN/_new 2019-08-05 10:36:06.767336385 +0200
@@ -17,7 +17,7 @@
Name: epiphany
-Version: 3.32.3
+Version: 3.32.4
Release: 0
Summary: GNOME Web Browser
License: GPL-3.0-or-later
@@ -25,8 +25,6 @@
URL: https://wiki.gnome.org/Apps/Web
Source0: https://download.gnome.org/sources/epiphany/3.32/%{name}-%{version}.tar.xz
Source99: %{name}-rpmlintrc
-# PATCH-FIX-UPSTREAM epiphany-web-app-utils_Fix-crash.patch -- Add 2 upstream crash fixes.
-Patch0: epiphany-web-app-utils_Fix-crash.patch
BuildRequires: fdupes
BuildRequires: meson >= 0.42.0
++++++ epiphany-3.32.3.tar.xz -> epiphany-3.32.4.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/NEWS new/epiphany-3.32.4/NEWS
--- old/epiphany-3.32.3/NEWS 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/NEWS 2019-07-30 22:57:44.000000000 +0200
@@ -1,3 +1,11 @@
+3.32.4 - July 30, 2019
+======================
+
+- Hide certain context menu entries from nondownloadable videos
+- Fix crash when entering application manager
+- Fix JS type error when loading forms without action attribute
+- Fix miscellaneous programming errors
+
3.32.3 - June 11, 2019
======================
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/embed/web-extension/resources/js/ephy.js new/epiphany-3.32.4/embed/web-extension/resources/js/ephy.js
--- old/epiphany-3.32.3/embed/web-extension/resources/js/ephy.js 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/embed/web-extension/resources/js/ephy.js 2019-07-30 22:57:44.000000000 +0200
@@ -593,9 +593,12 @@
_sensitiveElementFocused(event)
{
- let url = new URL(this._form.action);
- // Warning: we do not whitelist localhost because it could be redirected by DNS.
- let isInsecureAction = url.protocol == 'http:' && url.hostname != "127.0.0.1" && url.hostname != "::1";
+ let isInsecureAction = false;
+ if (this._form.action) {
+ let url = new URL(this._form.action);
+ // Warning: we do not whitelist localhost because it could be redirected by DNS.
+ isInsecureAction = url.protocol == 'http:' && url.hostname != "127.0.0.1" && url.hostname != "::1";
+ }
window.webkit.messageHandlers.sensitiveFormFocused.postMessage(this._sensitiveElementMessageSerializer(this._pageID, isInsecureAction));
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/lib/ephy-settings.c new/epiphany-3.32.4/lib/ephy-settings.c
--- old/epiphany-3.32.3/lib/ephy-settings.c 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/lib/ephy-settings.c 2019-07-30 22:57:44.000000000 +0200
@@ -89,15 +89,37 @@
ephy_settings_init ();
gsettings = g_hash_table_lookup (settings, schema);
+ if (gsettings)
+ return gsettings;
- if (gsettings == NULL) {
- gsettings = g_settings_new (schema);
- if (gsettings == NULL)
- g_warning ("Invalid schema %s requested", schema);
- else
- g_hash_table_insert (settings, g_strdup (schema), gsettings);
+ if (strcmp (schema, EPHY_PREFS_WEB_APP_SCHEMA) == 0) {
+ /* EPHY_PREFS_WEB_APP_SCHEMA won't be added to the settings table if the
+ * ephy_profile_dir_is_web_application() is FALSE. But we can still get
+ * here in EPHY_EMBED_SHELL_MODE_APPLICATION if the profile dir is broken
+ * such that its .app file is missing. This includes any web apps created by
+ * Epiphany 3.30 or earlier that were migrated to 3.32 before 3.32.3 before
+ * the main profile migration. This generally means anybody using Epiphany
+ * only for web apps has wound up with broken web apps after the migration.
+ *
+ * We can only crash, but it's nicer to crash here rather than crash later.
+ *
+ * https://gitlab.gnome.org/GNOME/epiphany/issues/713
+ */
+ g_error ("Epiphany is trying to access web app settings outside web app"
+ " mode. Your web app may be broken. If so, you must delete it and"
+ " recreate. See epiphany#713.");
}
+ /* schema must not be relocatable, or g_settings_new() will crash. */
+ for (guint i = 0; i < G_N_ELEMENTS (ephy_prefs_relocatable_schemas); i++)
+ g_assert (strcmp (schema, ephy_prefs_relocatable_schemas[i].schema) != 0);
+
+ gsettings = g_settings_new (schema);
+ if (gsettings == NULL)
+ g_warning ("Invalid schema %s requested", schema);
+ else
+ g_hash_table_insert (settings, g_strdup (schema), gsettings);
+
return gsettings;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/lib/ephy-web-app-utils.c new/epiphany-3.32.4/lib/ephy-web-app-utils.c
--- old/epiphany-3.32.3/lib/ephy-web-app-utils.c 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/lib/ephy-web-app-utils.c 2019-07-30 22:57:44.000000000 +0200
@@ -627,7 +627,7 @@
if (g_file_test (app_file, G_FILE_TEST_EXISTS))
applications = g_list_prepend (applications, app);
else
- g_object_unref (app);
+ g_free (app);
} else
applications = g_list_prepend (applications, app);
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/meson.build new/epiphany-3.32.4/meson.build
--- old/epiphany-3.32.3/meson.build 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/meson.build 2019-07-30 22:57:44.000000000 +0200
@@ -1,6 +1,6 @@
project('epiphany', 'c',
license: 'GPL3+',
- version: '3.32.3',
+ version: '3.32.4',
meson_version: '>= 0.42.0',
default_options: ['c_std=gnu11']
)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/src/ephy-action-bar-start.c new/epiphany-3.32.4/src/ephy-action-bar-start.c
--- old/epiphany-3.32.3/src/ephy-action-bar-start.c 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/src/ephy-action-bar-start.c 2019-07-30 22:57:44.000000000 +0200
@@ -473,6 +473,8 @@
EphyActionBarStart *action_bar_start = EPHY_ACTION_BAR_START (object);
EphyEmbedShell *embed_shell;
+ G_OBJECT_CLASS (ephy_action_bar_start_parent_class)->constructed (object);
+
gtk_widget_init_template (GTK_WIDGET (action_bar_start));
/* Back */
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/src/ephy-action-bar.c new/epiphany-3.32.4/src/ephy-action-bar.c
--- old/epiphany-3.32.3/src/ephy-action-bar.c 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/src/ephy-action-bar.c 2019-07-30 22:57:44.000000000 +0200
@@ -97,6 +97,8 @@
{
EphyActionBar *action_bar = EPHY_ACTION_BAR (object);
+ G_OBJECT_CLASS (ephy_action_bar_parent_class)->constructed (object);
+
g_signal_connect_object (action_bar->window, "notify::chrome",
G_CALLBACK (sync_chromes_visibility), action_bar,
G_CONNECT_SWAPPED);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/src/ephy-window.c new/epiphany-3.32.4/src/ephy-window.c
--- old/epiphany-3.32.3/src/ephy-window.c 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/src/ephy-window.c 2019-07-30 22:57:44.000000000 +0200
@@ -1479,8 +1479,8 @@
gboolean is_document = FALSE;
gboolean is_image = FALSE;
gboolean is_media = FALSE;
- gboolean is_video = FALSE;
- gboolean is_audio = FALSE;
+ gboolean is_downloadable_video = FALSE;
+ gboolean is_downloadable_audio = FALSE;
gboolean can_search_selection = FALSE;
char *search_selection_action_name = NULL;
const char *selected_text = NULL;
@@ -1515,14 +1515,14 @@
toggle_loop_item = find_item_in_context_menu (context_menu, WEBKIT_CONTEXT_MENU_ACTION_TOGGLE_MEDIA_LOOP);
fullscreen_item = find_item_in_context_menu (context_menu, WEBKIT_CONTEXT_MENU_ACTION_ENTER_VIDEO_FULLSCREEN);
- item = find_item_in_context_menu (context_menu, WEBKIT_CONTEXT_MENU_ACTION_COPY_VIDEO_LINK_TO_CLIPBOARD);
+ item = find_item_in_context_menu (context_menu, WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK);
if (item) {
- is_video = TRUE;
+ is_downloadable_video = TRUE;
g_object_unref (item);
} else {
- item = find_item_in_context_menu (context_menu, WEBKIT_CONTEXT_MENU_ACTION_COPY_AUDIO_LINK_TO_CLIPBOARD);
+ item = find_item_in_context_menu (context_menu, WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_AUDIO_TO_DISK);
if (item) {
- is_audio = TRUE;
+ is_downloadable_audio = TRUE;
g_object_unref (item);
}
}
@@ -1695,7 +1695,7 @@
add_item_to_context_menu (context_menu, fullscreen_item);
webkit_context_menu_append (context_menu,
webkit_context_menu_item_new_separator ());
- if (is_video) {
+ if (is_downloadable_video) {
if (!app_mode) {
add_action_to_context_menu (context_menu, popup_action_group,
"open-video-in-new-window", window);
@@ -1706,7 +1706,7 @@
"save-video-as", window);
add_action_to_context_menu (context_menu, popup_action_group,
"copy-video-location", window);
- } else if (is_audio) {
+ } else if (is_downloadable_audio) {
if (!app_mode) {
add_action_to_context_menu (context_menu, popup_action_group,
"open-audio-in-new-window", window);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/epiphany-3.32.3/tests/meson.build new/epiphany-3.32.4/tests/meson.build
--- old/epiphany-3.32.3/tests/meson.build 2019-06-12 00:41:04.000000000 +0200
+++ new/epiphany-3.32.4/tests/meson.build 2019-07-30 22:57:44.000000000 +0200
@@ -169,15 +169,15 @@
# env: envs
# )
- if get_option('network_tests').enabled()
- gsb_service_test = executable('test-ephy-gsb-service',
- 'ephy-gsb-service-test.c',
- dependencies: ephymain_dep
- )
- test('GSB service test',
- gsb_service_test,
- env: envs,
- timeout: 90 # slow!
- )
- endif
+ #if get_option('network_tests').enabled()
+ # gsb_service_test = executable('test-ephy-gsb-service',
+ # 'ephy-gsb-service-test.c',
+ # dependencies: ephymain_dep
+ # )
+ # test('GSB service test',
+ # gsb_service_test,
+ # env: envs,
+ # timeout: 90 # slow!
+ # )
+ #endif
endif