Hello community, here is the log from the commit of package kiconthemes for openSUSE:Factory checked in at 2019-04-19 21:22:45 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kiconthemes (Old) and /work/SRC/openSUSE:Factory/.kiconthemes.new.5536 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "kiconthemes" Fri Apr 19 21:22:45 2019 rev:70 rq:695226 version:5.57.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kiconthemes/kiconthemes.changes 2019-03-21 09:46:04.598900632 +0100 +++ /work/SRC/openSUSE:Factory/.kiconthemes.new.5536/kiconthemes.changes 2019-04-19 21:22:55.907763244 +0200 @@ -1,0 +2,11 @@ +Sun Apr 14 20:21:43 UTC 2019 - lbeltrame@kde.org + +- Update to 5.57.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.57.0.php +- Changes since 5.56.0: + * [kiconthemes] compiles without foreach + * Fix padding icon that doesn't exactly match the requested size (kde#397106) + +------------------------------------------------------------------- Old: ---- kiconthemes-5.56.0.tar.xz New: ---- kiconthemes-5.57.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kiconthemes.spec ++++++ --- /var/tmp/diff_new_pack.4xyGsS/_old 2019-04-19 21:22:56.351763810 +0200 +++ /var/tmp/diff_new_pack.4xyGsS/_new 2019-04-19 21:22:56.355763815 +0200 @@ -17,14 +17,14 @@ %define lname libKF5IconThemes5 -%define _tar_path 5.56 +%define _tar_path 5.57 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} %bcond_without lang Name: kiconthemes -Version: 5.56.0 +Version: 5.57.0 Release: 0 Summary: Icon GUI utilities License: LGPL-2.1-or-later AND GPL-2.0-or-later ++++++ kiconthemes-5.56.0.tar.xz -> kiconthemes-5.57.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/.gitignore new/kiconthemes-5.57.0/.gitignore --- old/kiconthemes-5.56.0/.gitignore 1970-01-01 01:00:00.000000000 +0100 +++ new/kiconthemes-5.57.0/.gitignore 2019-04-07 09:28:40.000000000 +0200 @@ -0,0 +1,21 @@ +# Ignore the following files +*~ +*.[oa] +*.diff +*.kate-swp +*.kdev4 +.kdev_include_paths +*.kdevelop.pcs +*.moc +*.moc.cpp +*.orig +*.user +.*.swp +.swp.* +Doxyfile +Makefile +avail +random_seed +/build*/ +CMakeLists.txt.user* +*.unc-backup* diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/CMakeLists.txt new/kiconthemes-5.57.0/CMakeLists.txt --- old/kiconthemes-5.56.0/CMakeLists.txt 2019-03-02 14:41:31.000000000 +0100 +++ new/kiconthemes-5.57.0/CMakeLists.txt 2019-04-07 09:28:40.000000000 +0200 @@ -1,12 +1,12 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.56.0") # handled by release scripts -set(KF5_DEP_VERSION "5.56.0") # handled by release scripts +set(KF5_VERSION "5.57.0") # handled by release scripts +set(KF5_DEP_VERSION "5.57.0") # handled by release scripts project(KIconThemes VERSION ${KF5_VERSION}) # ECM setup include(FeatureSummary) -find_package(ECM 5.56.0 NO_MODULE) +find_package(ECM 5.57.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules") feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -49,6 +49,7 @@ remove_definitions(-DQT_NO_CAST_FROM_ASCII) remove_definitions(-DQT_NO_CAST_FROM_BYTEARRAY) +add_definitions(-DQT_NO_FOREACH) add_definitions(-DTRANSLATION_DOMAIN=\"kiconthemes5\") if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/po/id/kiconthemes5.po new/kiconthemes-5.57.0/po/id/kiconthemes5.po --- old/kiconthemes-5.56.0/po/id/kiconthemes5.po 2019-03-02 14:41:31.000000000 +0100 +++ new/kiconthemes-5.57.0/po/id/kiconthemes5.po 2019-04-07 09:28:40.000000000 +0200 @@ -14,7 +14,7 @@ "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" -"Plural-Forms: nplurals=2; plural=n != 1;\n" +"Plural-Forms: nplurals=2; plural=(n != 1);\n" "X-Generator: Lokalize 2.0\n" #: kicondialog.cpp:261 kicondialog.cpp:273 kicondialog.cpp:605 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/po/zh_CN/kiconthemes5.po new/kiconthemes-5.57.0/po/zh_CN/kiconthemes5.po --- old/kiconthemes-5.56.0/po/zh_CN/kiconthemes5.po 2019-03-02 14:41:31.000000000 +0100 +++ new/kiconthemes-5.57.0/po/zh_CN/kiconthemes5.po 2019-04-07 09:28:40.000000000 +0200 @@ -17,7 +17,7 @@ "Project-Id-Version: kdeorg\n" "Report-Msgid-Bugs-To: http://bugs.kde.org\n" "POT-Creation-Date: 2018-10-26 03:46+0200\n" -"PO-Revision-Date: 2019-02-20 23:16\n" +"PO-Revision-Date: 2019-03-07 09:22\n" "Last-Translator: guoyunhe \n" "Language-Team: Chinese Simplified\n" "Language: zh_CN\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/src/kiconengine.cpp new/kiconthemes-5.57.0/src/kiconengine.cpp --- old/kiconthemes-5.56.0/src/kiconengine.cpp 2019-03-02 14:41:31.000000000 +0100 +++ new/kiconthemes-5.57.0/src/kiconengine.cpp 2019-04-07 09:28:40.000000000 +0200 @@ -104,7 +104,7 @@ return pix; } - QPixmap pix2(size * pix.devicePixelRatio()); + QPixmap pix2(size); pix2.setDevicePixelRatio(pix.devicePixelRatio()); pix2.fill(QColor(0, 0, 0, 0)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/src/kiconloader.cpp new/kiconthemes-5.57.0/src/kiconloader.cpp --- old/kiconthemes-5.56.0/src/kiconloader.cpp 2019-03-02 14:41:31.000000000 +0100 +++ new/kiconthemes-5.57.0/src/kiconloader.cpp 2019-04-07 09:28:40.000000000 +0200 @@ -1079,7 +1079,7 @@ // Once everone uses that to look up mimetype icons, we can kill the fallback code // from this method. - foreach (KIconThemeNode *themeNode, links) { + for (KIconThemeNode *themeNode : qAsConst(links)) { const QString path = themeNode->theme->iconPathByName(name, size, KIconLoader::MatchBest, scale); if (!path.isEmpty()) { return path; @@ -1091,7 +1091,7 @@ } bool genericFallback = false; QString path; - foreach (KIconThemeNode *themeNode, links) { + for (KIconThemeNode *themeNode : qAsConst(links)) { QString currentName = name; while (!currentName.isEmpty()) { @@ -1464,7 +1464,7 @@ QString path; - foreach (KIconThemeNode *themeNode, d->links) { + for (KIconThemeNode *themeNode : qAsConst(d->links)) { path = themeNode->theme->iconPath(file, size, KIconLoader::MatchExact); if (!path.isEmpty()) { break; @@ -1472,7 +1472,7 @@ } if (path.isEmpty()) { - foreach (KIconThemeNode *themeNode, d->links) { + for (KIconThemeNode *themeNode : qAsConst(d->links)) { path = themeNode->theme->iconPath(file, size, KIconLoader::MatchBest); if (!path.isEmpty()) { break; @@ -1523,7 +1523,8 @@ return lst; } - foreach (const QString &entry, dir.entryList()) { + const auto entryList = dir.entryList(); + for (const QString &entry : entryList) { if (!(entry.leftRef(4)).toUInt()) { continue; } @@ -1585,7 +1586,7 @@ size = -group_or_size; } - foreach (KIconThemeNode *themeNode, d->links) { + for (KIconThemeNode *themeNode : qAsConst(d->links)) { themeNode->queryIconsByContext(&result, size, context); } @@ -1626,7 +1627,7 @@ size = -group_or_size; } - foreach (KIconThemeNode *themeNode, d->links) { + for (KIconThemeNode *themeNode : qAsConst(d->links)) { themeNode->queryIcons(&result, size, context); } @@ -1655,7 +1656,7 @@ { d->initIconThemes(); - foreach (KIconThemeNode *themeNode, d->links) + for (KIconThemeNode *themeNode : qAsConst(d->links)) if (themeNode->theme->hasContext(context)) { return true; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kiconthemes-5.56.0/src/kicontheme.cpp new/kiconthemes-5.57.0/src/kicontheme.cpp --- old/kiconthemes-5.56.0/src/kicontheme.cpp 2019-03-02 14:41:31.000000000 +0100 +++ new/kiconthemes-5.57.0/src/kicontheme.cpp 2019-04-07 09:28:40.000000000 +0200 @@ -465,7 +465,8 @@ { // Try to find exact match QStringList result; - foreach (KIconThemeDir* dir, d->mDirs + d->mScaledDirs) { + const auto listDirs = d->mDirs + d->mScaledDirs; + for (KIconThemeDir* dir : listDirs) { if ((context != KIconLoader::Any) && (context != dir->context())) { continue; } @@ -521,8 +522,8 @@ // Usually, only the 0, 6 (22-16), 10 (32-22), 16 (48-32 or 32-16), // 26 (48-22) and 32 (48-16) will be used, but who knows if someone // will make icon themes with different icon sizes. - - foreach (KIconThemeDir *dir, d->mDirs + d->mScaledDirs) { + const auto listDirs = d->mDirs + d->mScaledDirs; + for (KIconThemeDir* dir : listDirs) { if ((context != KIconLoader::Any) && (context != dir->context())) { continue; } @@ -540,7 +541,8 @@ bool KIconTheme::hasContext(KIconLoader::Context context) const { - foreach (KIconThemeDir *dir, d->mDirs + d->mScaledDirs) { + const auto listDirs = d->mDirs + d->mScaledDirs; + for (KIconThemeDir* dir : listDirs) { if ((context == KIconLoader::Any) || (context == dir->context())) { return true; } @@ -555,7 +557,7 @@ QString KIconTheme::iconPathByName(const QString &iconName, int size, KIconLoader::MatchType match, qreal scale) const { - foreach(const QString ¤t, d->mExtensions) { + for (const QString ¤t : qAsConst(d->mExtensions)) { const QString path = iconPath(iconName + current, size, match, scale); if (!path.isEmpty()) return path;