Hello community,
here is the log from the commit of package filezilla for openSUSE:Factory checked in at 2018-11-06 14:34:03
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/filezilla (Old)
and /work/SRC/openSUSE:Factory/.filezilla.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "filezilla"
Tue Nov 6 14:34:03 2018 rev:70 rq:646181 version:3.38.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/filezilla/filezilla.changes 2018-10-29 14:58:48.706012090 +0100
+++ /work/SRC/openSUSE:Factory/.filezilla.new/filezilla.changes 2018-11-06 14:36:01.388901302 +0100
@@ -1,0 +2,8 @@
+Sat Nov 3 09:08:37 UTC 2018 - ecsos@opensuse.org
+
+- update to 3.38.1
+ * Bugfixes and minor changes:
+ - Fixed crash if transferring three or more files in parallel
+ when speed limits are enabled
+
+-------------------------------------------------------------------
Old:
----
FileZilla_3.38.0_src.tar.bz2
New:
----
FileZilla_3.38.1_src.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ filezilla.spec ++++++
--- /var/tmp/diff_new_pack.bfDwbW/_old 2018-11-06 14:36:24.180866833 +0100
+++ /var/tmp/diff_new_pack.bfDwbW/_new 2018-11-06 14:36:24.184866826 +0100
@@ -17,7 +17,7 @@
Name: filezilla
-Version: 3.38.0
+Version: 3.38.1
Release: 0
Summary: A GUI FTP and SFTP Client
License: GPL-2.0-or-later
++++++ FileZilla_3.38.0_src.tar.bz2 -> FileZilla_3.38.1_src.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/filezilla-3.38.0/NEWS new/filezilla-3.38.1/NEWS
--- old/filezilla-3.38.0/NEWS 2018-10-26 14:24:53.000000000 +0200
+++ new/filezilla-3.38.1/NEWS 2018-10-27 19:40:07.000000000 +0200
@@ -10,6 +10,10 @@
*nix: Unix (e.g BSD) and Unix-like systems (e.g. Linux)
OS X: Apple Mac OS X
+3.38.1 (2018-10-27)
+
+- Fixed crash if transferring three or more files in parallel when speed limits are enabled
+
3.38.0 (2018-10-26)
- Updated translations
@@ -18,7 +22,7 @@
+ Refreshing remote file list while holding Ctrl now clears the remote directory cache for the current server
+ Changed default logon type if creating a new site in the Site Manager
-- Fixed state of controles in the Site Manager when creating a new site after the previously viewed site has been predefined
+- Fixed state of controls in the Site Manager when creating a new site after the previously viewed site has been predefined
- Fixed dragging remote files to queue
- Building and running FileZilla now depends on libfilezilla >= 0.15.0 (https://lib.filezilla-project.org/)
- Improve compatibility with GnuTLS 3.6.x
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/filezilla-3.38.0/configure new/filezilla-3.38.1/configure
--- old/filezilla-3.38.0/configure 2018-10-26 14:25:08.000000000 +0200
+++ new/filezilla-3.38.1/configure 2018-10-27 19:40:22.000000000 +0200
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for FileZilla 3.38.0.
+# Generated by GNU Autoconf 2.69 for FileZilla 3.38.1.
#
# Report bugs to .
#
@@ -590,8 +590,8 @@
# Identity of this package.
PACKAGE_NAME='FileZilla'
PACKAGE_TARNAME='filezilla'
-PACKAGE_VERSION='3.38.0'
-PACKAGE_STRING='FileZilla 3.38.0'
+PACKAGE_VERSION='3.38.1'
+PACKAGE_STRING='FileZilla 3.38.1'
PACKAGE_BUGREPORT='tim.kosse@filezilla-project.org'
PACKAGE_URL='https://filezilla-project.org/'
@@ -1467,7 +1467,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures FileZilla 3.38.0 to adapt to many kinds of systems.
+\`configure' configures FileZilla 3.38.1 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1538,7 +1538,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of FileZilla 3.38.0:";;
+ short | recursive ) echo "Configuration of FileZilla 3.38.1:";;
esac
cat <<\_ACEOF
@@ -1720,7 +1720,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-FileZilla configure 3.38.0
+FileZilla configure 3.38.1
generated by GNU Autoconf 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
@@ -2385,7 +2385,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by FileZilla $as_me 3.38.0, which was
+It was created by FileZilla $as_me 3.38.1, which was
generated by GNU Autoconf 2.69. Invocation command line was
$ $0 $@
@@ -3251,7 +3251,7 @@
# Define the identity of the package.
PACKAGE='filezilla'
- VERSION='3.38.0'
+ VERSION='3.38.1'
cat >>confdefs.h <<_ACEOF
@@ -22381,7 +22381,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by FileZilla $as_me 3.38.0, which was
+This file was extended by FileZilla $as_me 3.38.1, which was
generated by GNU Autoconf 2.69. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -22448,7 +22448,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
-FileZilla config.status 3.38.0
+FileZilla config.status 3.38.1
configured by $0, generated by GNU Autoconf 2.69,
with options \\"\$ac_cs_config\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/filezilla-3.38.0/configure.ac new/filezilla-3.38.1/configure.ac
--- old/filezilla-3.38.0/configure.ac 2018-10-26 14:24:53.000000000 +0200
+++ new/filezilla-3.38.1/configure.ac 2018-10-27 19:40:07.000000000 +0200
@@ -1,4 +1,4 @@
-AC_INIT([FileZilla],[3.38.0],[tim.kosse@filezilla-project.org],[],[https://filezilla-project.org/])
+AC_INIT([FileZilla],[3.38.1],[tim.kosse@filezilla-project.org],[],[https://filezilla-project.org/])
AC_CONFIG_HEADERS([src/include/config.h])
AC_CONFIG_MACRO_DIR([m4])
AC_CONFIG_AUX_DIR(config)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/filezilla-3.38.0/locales/filezilla.pot new/filezilla-3.38.1/locales/filezilla.pot
--- old/filezilla-3.38.0/locales/filezilla.pot 2018-10-26 14:25:16.000000000 +0200
+++ new/filezilla-3.38.1/locales/filezilla.pot 2018-10-27 19:40:30.000000000 +0200
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: https://trac.filezilla-project.org/\n"
-"POT-Creation-Date: 2018-10-26 14:25+0200\n"
+"POT-Creation-Date: 2018-10-27 19:40+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME \n"
"Language-Team: LANGUAGE \n"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/filezilla-3.38.0/src/engine/ratelimiter.cpp new/filezilla-3.38.1/src/engine/ratelimiter.cpp
--- old/filezilla-3.38.0/src/engine/ratelimiter.cpp 2018-10-05 08:47:26.000000000 +0200
+++ new/filezilla-3.38.1/src/engine/ratelimiter.cpp 2018-10-27 19:40:07.000000000 +0200
@@ -195,14 +195,17 @@
}
tokens = 0;
- for (size_t i = 0; i < unsaturated; ++i) {
- auto * object = scratchBuf_[i];
+ for (size_t j = 0; j < unsaturated; ) {
+ auto * object = scratchBuf_[j];
object->bytesAvailable_[i] += tokensPerObject;
if (object->bytesAvailable_[i] > maxTokens) {
tokens += object->bytesAvailable_[i] - maxTokens;
object->bytesAvailable_[i] = maxTokens;
- scratchBuf_[i] = scratchBuf_[--unsaturated];
+ scratchBuf_[j] = scratchBuf_[--unsaturated];
+ }
+ else {
+ ++j;
}
}
}
@@ -276,6 +279,7 @@
void CRateLimiterObject::UpdateUsage(CRateLimiter::rate_direction direction, int usedBytes)
{
+ assert(0 <= direction && direction <= 1);
assert(usedBytes <= bytesAvailable_[direction]);
if (usedBytes > bytesAvailable_[direction]) {
bytesAvailable_[direction] = 0;
@@ -287,11 +291,13 @@
void CRateLimiterObject::Wait(CRateLimiter::rate_direction direction)
{
+ assert(0 <= direction && direction <= 1);
assert(bytesAvailable_[direction] == 0);
waiting_[direction] = true;
}
bool CRateLimiterObject::IsWaiting(CRateLimiter::rate_direction direction) const
{
+ assert(0 <= direction && direction <= 1);
return waiting_[direction];
}