Hello community, here is the log from the commit of package gnome-disk-utility for openSUSE:Factory checked in at 2018-06-02 11:56:09 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-disk-utility (Old) and /work/SRC/openSUSE:Factory/.gnome-disk-utility.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "gnome-disk-utility" Sat Jun 2 11:56:09 2018 rev:61 rq:613438 version:3.28.3 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-disk-utility/gnome-disk-utility.changes 2018-05-10 15:46:35.947422876 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-disk-utility.new/gnome-disk-utility.changes 2018-06-02 11:56:11.731093304 +0200 @@ -1,0 +2,8 @@ +Thu May 31 12:45:39 UTC 2018 - bjorn.lie@gmail.com + +- Update to version 3.28.3: + + Query NTFS tooling from UDisks (> 2.7.2). Disks queried for + mkntfs in the $PATH directly which does not work for + non-sudoers without /sbin. + +------------------------------------------------------------------- Old: ---- gnome-disk-utility-3.28.2.tar.xz New: ---- gnome-disk-utility-3.28.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-disk-utility.spec ++++++ --- /var/tmp/diff_new_pack.70HBfG/_old 2018-06-02 11:56:13.343034193 +0200 +++ /var/tmp/diff_new_pack.70HBfG/_new 2018-06-02 11:56:13.343034193 +0200 @@ -17,7 +17,7 @@ Name: gnome-disk-utility -Version: 3.28.2 +Version: 3.28.3 Release: 0 Summary: Disks application for dealing with storage devices License: GPL-2.0-or-later ++++++ gnome-disk-utility-3.28.2.tar.xz -> gnome-disk-utility-3.28.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/NEWS new/gnome-disk-utility-3.28.3/NEWS --- old/gnome-disk-utility-3.28.2/NEWS 2018-05-08 08:43:29.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/NEWS 2018-05-31 11:32:11.000000000 +0200 @@ -1,3 +1,11 @@ +3.28.3 - May 31, 2018 +===================== + +Kai Lüke: + * Query NTFS tooling from UDisks (> 2.7.2) + Disks queried for mkntfs in the $PATH directly + which does not work for non-sudoers without /sbin + 3.28.2 - May 8, 2018 ==================== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/meson.build new/gnome-disk-utility-3.28.3/meson.build --- old/gnome-disk-utility-3.28.2/meson.build 2018-05-08 08:43:29.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/meson.build 2018-05-31 11:32:11.000000000 +0200 @@ -1,6 +1,6 @@ project( 'gnome-disk-utility', 'c', - version: '3.28.2', + version: '3.28.3', license: 'GPL2.0', default_options: 'buildtype=debugoptimized', meson_version: '>= 0.43.0' diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/src/disks/gducreatefilesystempage.c new/gnome-disk-utility-3.28.3/src/disks/gducreatefilesystempage.c --- old/gnome-disk-utility-3.28.2/src/disks/gducreatefilesystempage.c 2018-05-08 08:43:30.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/src/disks/gducreatefilesystempage.c 2018-05-31 11:32:11.000000000 +0200 @@ -183,7 +183,7 @@ } GduCreateFilesystemPage * -gdu_create_filesystem_page_new (gboolean show_custom, UDisksDrive *drive) +gdu_create_filesystem_page_new (UDisksClient *client, gboolean show_custom, UDisksDrive *drive) { GduCreateFilesystemPage *page; GduCreateFilesystemPagePrivate *priv; @@ -208,7 +208,7 @@ /* default FAT for flash and disks/media smaller than 20G (assumed to be flash cards) */ if (gdu_utils_is_flash (drive) || udisks_drive_get_size (drive) < 20UL * 1000UL*1000UL*1000UL || - !gdu_utils_is_ntfs_available () + !gdu_utils_is_ntfs_available (client) ) { gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (priv->all_radiobutton), TRUE); @@ -219,7 +219,7 @@ } } - gtk_widget_set_sensitive (GTK_WIDGET (priv->windows_radiobutton), gdu_utils_is_ntfs_available ()); + gtk_widget_set_sensitive (GTK_WIDGET (priv->windows_radiobutton), gdu_utils_is_ntfs_available (client)); return page; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/src/disks/gducreatefilesystempage.h new/gnome-disk-utility-3.28.3/src/disks/gducreatefilesystempage.h --- old/gnome-disk-utility-3.28.2/src/disks/gducreatefilesystempage.h 2018-05-08 08:43:30.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/src/disks/gducreatefilesystempage.h 2018-05-31 11:32:11.000000000 +0200 @@ -17,7 +17,8 @@ #define GDU_TYPE_CREATE_FILESYSTEM_PAGE gdu_create_filesystem_page_get_type () G_DECLARE_FINAL_TYPE (GduCreateFilesystemPage, gdu_create_filesystem_page, GDU, CREATE_FILESYSTEM_PAGE, GtkGrid) -GduCreateFilesystemPage *gdu_create_filesystem_page_new (gboolean show_custom, +GduCreateFilesystemPage *gdu_create_filesystem_page_new (UDisksClient *client, + gboolean show_custom, UDisksDrive *drive); const gchar * gdu_create_filesystem_page_get_name (GduCreateFilesystemPage *page); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/src/disks/gducreateformatdialog.c new/gnome-disk-utility-3.28.3/src/disks/gducreateformatdialog.c --- old/gnome-disk-utility-3.28.2/src/disks/gducreateformatdialog.c 2018-05-08 08:43:30.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/src/disks/gducreateformatdialog.c 2018-05-31 11:32:11.000000000 +0200 @@ -440,7 +440,7 @@ data->partition_page = NULL; } - data->filesystem_page = gdu_create_filesystem_page_new (show_custom, data->drive); + data->filesystem_page = gdu_create_filesystem_page_new (data->client, show_custom, data->drive); gtk_stack_add_titled (data->stack, GTK_WIDGET (data->filesystem_page), FORMAT_PAGE, _("Format Volume")); g_signal_connect (data->filesystem_page, "notify::complete", G_CALLBACK (update_dialog), data); data->other_page = gdu_create_other_page_new (data->client); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/src/libgdu/gduutils.c new/gnome-disk-utility-3.28.3/src/libgdu/gduutils.c --- old/gnome-disk-utility-3.28.2/src/libgdu/gduutils.c 2018-05-08 08:43:30.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/src/libgdu/gduutils.c 2018-05-31 11:32:11.000000000 +0200 @@ -872,18 +872,31 @@ /* ---------------------------------------------------------------------------------------------------- */ gboolean -gdu_utils_is_ntfs_available (void) +gdu_utils_is_ntfs_available (UDisksClient *client) { static gsize once = 0; static gboolean available = FALSE; if (g_once_init_enter (&once)) { +#ifdef HAVE_UDISKS2_7_2 + GVariant *out_available; + gchar *missing_util; + + if (udisks_manager_call_can_format_sync (udisks_client_get_manager (client), + "ntfs", &out_available, NULL, NULL)) + { + g_variant_get (out_available, "(bs)", &available, &missing_util); + g_variant_unref (out_available); + g_free (missing_util); + } +#else gchar *path; path = g_find_program_in_path ("mkntfs"); if (path != NULL) available = TRUE; g_free (path); +#endif g_once_init_leave (&once, (gsize) 1); } return available; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-disk-utility-3.28.2/src/libgdu/gduutils.h new/gnome-disk-utility-3.28.3/src/libgdu/gduutils.h --- old/gnome-disk-utility-3.28.2/src/libgdu/gduutils.h 2018-05-08 08:43:30.000000000 +0200 +++ new/gnome-disk-utility-3.28.3/src/libgdu/gduutils.h 2018-05-31 11:32:11.000000000 +0200 @@ -75,7 +75,7 @@ UDisksClient *client, GList *objects); -gboolean gdu_utils_is_ntfs_available (void); +gboolean gdu_utils_is_ntfs_available (UDisksClient *client); #ifdef HAVE_UDISKS2_7_2