Hello community, here is the log from the commit of package yast2-samba-server for openSUSE:Factory checked in at 2018-03-04 11:50:31 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-samba-server (Old) and /work/SRC/openSUSE:Factory/.yast2-samba-server.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-samba-server" Sun Mar 4 11:50:31 2018 rev:77 rq:581728 version:4.0.1 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-samba-server/yast2-samba-server.changes 2017-09-23 21:32:02.724729261 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-samba-server.new/yast2-samba-server.changes 2018-03-04 11:50:33.002586250 +0100 @@ -1,0 +2,12 @@ +Thu Mar 1 12:40:05 UTC 2018 - knut.anderssen@suse.com + +- Use firewalld samba service definition (bsc#1083456) +- 4.0.1 + +------------------------------------------------------------------- +Mon Feb 5 10:06:46 UTC 2018 - knut.anderssen@suse.com + +- SuSEFirewall2 replaced by firewalld (fate#323460) +- 4.0.0 + +------------------------------------------------------------------- Old: ---- yast2-samba-server-3.2.2.tar.bz2 New: ---- yast2-samba-server-4.0.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-samba-server.spec ++++++ --- /var/tmp/diff_new_pack.sc0T0x/_old 2018-03-04 11:50:33.590564950 +0100 +++ /var/tmp/diff_new_pack.sc0T0x/_new 2018-03-04 11:50:33.590564950 +0100 @@ -1,7 +1,7 @@ # # spec file for package yast2-samba-server # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: yast2-samba-server -Version: 3.2.2 +Version: 4.0.1 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -31,7 +31,8 @@ BuildRequires: perl-XML-Writer BuildRequires: samba-client BuildRequires: update-desktop-files -BuildRequires: yast2 >= 3.1.53 +# SuSEFirewall2 replaced by firewalld (fate#323460) +BuildRequires: yast2 >= 4.0.39 BuildRequires: yast2-devtools >= 3.1.10 BuildRequires: yast2-ldap BuildRequires: yast2-perl-bindings @@ -40,8 +41,8 @@ BuildRequires: yast2-users Requires: perl-Crypt-SmbHash -# Service.Active -Requires: yast2 >= 3.1.53 +# SuSEFirewall2 replaced by firewalld (fate#323460) +Requires: yast2 >= 4.0.39 Requires: yast2-ldap >= 3.1.2 Requires: yast2-network Requires: yast2-perl-bindings ++++++ yast2-samba-server-3.2.2.tar.bz2 -> yast2-samba-server-4.0.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-samba-server-3.2.2/package/yast2-samba-server.changes new/yast2-samba-server-4.0.1/package/yast2-samba-server.changes --- old/yast2-samba-server-3.2.2/package/yast2-samba-server.changes 2017-09-22 04:06:51.176440424 +0200 +++ new/yast2-samba-server-4.0.1/package/yast2-samba-server.changes 2018-03-01 15:29:45.000000000 +0100 @@ -1,4 +1,16 @@ ------------------------------------------------------------------- +Thu Mar 1 12:40:05 UTC 2018 - knut.anderssen@suse.com + +- Use firewalld samba service definition (bsc#1083456) +- 4.0.1 + +------------------------------------------------------------------- +Mon Feb 5 10:06:46 UTC 2018 - knut.anderssen@suse.com + +- SuSEFirewall2 replaced by firewalld (fate#323460) +- 4.0.0 + +------------------------------------------------------------------- Wed Jul 26 07:23:28 UTC 2017 - scabrero@suse.com - Drop NT style PDC/BDC configuration wizard (fate#323806) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-samba-server-3.2.2/package/yast2-samba-server.spec new/yast2-samba-server-4.0.1/package/yast2-samba-server.spec --- old/yast2-samba-server-3.2.2/package/yast2-samba-server.spec 2017-09-22 04:06:51.176440424 +0200 +++ new/yast2-samba-server-4.0.1/package/yast2-samba-server.spec 2018-03-01 15:29:45.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-samba-server -Version: 3.2.2 +Version: 4.0.1 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -33,7 +33,8 @@ BuildRequires: perl-XML-Writer BuildRequires: samba-client BuildRequires: update-desktop-files -BuildRequires: yast2 >= 3.1.53 +# SuSEFirewall2 replaced by firewalld (fate#323460) +BuildRequires: yast2 >= 4.0.39 BuildRequires: yast2-devtools >= 3.1.10 BuildRequires: yast2-ldap BuildRequires: yast2-perl-bindings @@ -42,8 +43,8 @@ BuildRequires: yast2-users Requires: perl-Crypt-SmbHash -# Service.Active -Requires: yast2 >= 3.1.53 +# SuSEFirewall2 replaced by firewalld (fate#323460) +Requires: yast2 >= 4.0.39 Requires: yast2-ldap >= 3.1.2 Requires: yast2-perl-bindings Requires: yast2-network diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-samba-server-3.2.2/src/include/samba-server/dialogs.rb new/yast2-samba-server-4.0.1/src/include/samba-server/dialogs.rb --- old/yast2-samba-server-3.2.2/src/include/samba-server/dialogs.rb 2017-09-22 04:06:51.176440424 +0200 +++ new/yast2-samba-server-4.0.1/src/include/samba-server/dialogs.rb 2018-03-01 15:29:45.000000000 +0100 @@ -1282,11 +1282,8 @@ # BNC #247344, BNC #541958 (comment #18) "FIREWALL" => CWMFirewallInterfaces.CreateOpenFirewallWidget( { - "services" => [ - "service:samba-server", - "service:netbios-server", - "service:samba-client" - ], + # Firewalld default service definition + "services" => ["samba"], "display_details" => true } ), diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-samba-server-3.2.2/src/modules/SambaServer.pm new/yast2-samba-server-4.0.1/src/modules/SambaServer.pm --- old/yast2-samba-server-3.2.2/src/modules/SambaServer.pm 2017-09-22 04:06:51.180440424 +0200 +++ new/yast2-samba-server-4.0.1/src/modules/SambaServer.pm 2018-03-01 15:29:45.000000000 +0100 @@ -48,7 +48,7 @@ YaST::YCP::Import("Summary"); YaST::YCP::Import("Progress"); #HELPME: YaST::YCP::Import("Directory"); -YaST::YCP::Import("SuSEFirewall"); +YaST::YCP::Import("FirewalldWrapper"); YaST::YCP::Import("PackageSystem"); YaST::YCP::Import("SambaRole"); @@ -215,7 +215,7 @@ # 6: read firewall setting Progress->NextStage(); my $po = Progress->set(0); - SuSEFirewall->Read(); + FirewalldWrapper->read(); Progress->set($po); # 7: Read other settings @@ -340,7 +340,7 @@ # 5: save firewall settings Progress->NextStage(); my $po = Progress->set(0); - SuSEFirewall->Write(); + FirewalldWrapper->write(); Progress->set($po); # progress finished