Hello community, here is the log from the commit of package rubygem-facter for openSUSE:Factory checked in at 2015-11-28 15:19:26 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/rubygem-facter (Old) and /work/SRC/openSUSE:Factory/.rubygem-facter.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "rubygem-facter" Changes: -------- --- /work/SRC/openSUSE:Factory/rubygem-facter/rubygem-facter.changes 2015-08-27 08:57:53.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.rubygem-facter.new/rubygem-facter.changes 2015-11-28 15:19:31.000000000 +0100 @@ -1,0 +2,6 @@ +Thu Nov 19 11:51:17 UTC 2015 - tampakrap@opensuse.org + +- Version bump 2.4.4, see + http://docs.puppetlabs.com/facter/2.4/release_notes.html#facter-244 + +------------------------------------------------------------------- Old: ---- facter-2.4.3.gem New: ---- facter-2.4.4.gem ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rubygem-facter.spec ++++++ --- /var/tmp/diff_new_pack.huIwmN/_old 2015-11-28 15:19:32.000000000 +0100 +++ /var/tmp/diff_new_pack.huIwmN/_new 2015-11-28 15:19:32.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package rubygem-facter # -# Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -24,7 +24,7 @@ # Name: rubygem-facter -Version: 2.4.3 +Version: 2.4.4 Release: 0 %define mod_name facter %define mod_full_name %{mod_name}-%{version} ++++++ facter-2.4.3.gem -> facter-2.4.4.gem ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ext/build_defaults.yaml new/ext/build_defaults.yaml --- old/ext/build_defaults.yaml 1970-01-01 01:00:00.000000000 +0100 +++ new/ext/build_defaults.yaml 1970-01-01 01:00:00.000000000 +0100 @@ -2,14 +2,14 @@ packaging_url: 'git://github.com/puppetlabs/packaging.git --branch=master' packaging_repo: 'packaging' default_cow: 'base-squeeze-i386.cow' -cows: 'base-lucid-i386.cow base-lucid-amd64.cow base-precise-i386.cow base-precise-amd64.cow base-squeeze-i386.cow base-squeeze-amd64.cow base-stable-i386.cow base-stable-amd64.cow base-testing-i386.cow base-testing-amd64.cow base-trusty-i386.cow base-trusty-amd64.cow base-wheezy-i386.cow base-wheezy-amd64.cow' +cows: 'base-precise-i386.cow base-precise-amd64.cow base-squeeze-i386.cow base-squeeze-amd64.cow base-trusty-i386.cow base-trusty-amd64.cow base-wheezy-i386.cow base-wheezy-amd64.cow' pbuild_conf: '/etc/pbuilderrc' packager: 'puppetlabs' gpg_name: 'info@puppetlabs.com' gpg_key: '4BD6EC30' sign_tar: FALSE # a space separated list of mock configs -final_mocks: 'pl-el-5-i386 pl-el-5-x86_64 pl-el-6-i386 pl-el-6-x86_64 pl-el-7-x86_64 pl-fedora-19-i386 pl-fedora-19-x86_64 pl-fedora-20-i386 pl-fedora-20-x86_64' +final_mocks: 'pl-el-5-i386 pl-el-5-x86_64 pl-el-6-i386 pl-el-6-x86_64 pl-el-7-x86_64 pl-fedora-20-i386 pl-fedora-20-x86_64' yum_host: 'yum.puppetlabs.com' yum_repo_path: '/opt/repository/yum/' build_gem: TRUE diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/facter/application.rb new/lib/facter/application.rb --- old/lib/facter/application.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/lib/facter/application.rb 1970-01-01 01:00:00.000000000 +0100 @@ -160,7 +160,9 @@ "Enable timing.") { |v| Facter.timing(1) } opts.on("-p", "--puppet", - "Load the Puppet libraries, thus allowing Facter to load Puppet-specific facts.") { |v| load_puppet } + "(Deprecated: use `puppet facts` instead) Load the Puppet libraries, thus allowing Facter to load Puppet-specific facts.") do |v| + load_puppet + end opts.on_tail("-v", "--version", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/facter/dhcp_servers.rb new/lib/facter/dhcp_servers.rb --- old/lib/facter/dhcp_servers.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/lib/facter/dhcp_servers.rb 1970-01-01 01:00:00.000000000 +0100 @@ -24,7 +24,8 @@ Facter::Core::Execution.which('nmcli') end confine do - Facter::Util::DHCPServers.network_manager_state != 'unknown' + s = Facter::Util::DHCPServers.network_manager_state + !s.empty? && (s != 'unknown') end setcode do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/facter/ldom.rb new/lib/facter/ldom.rb --- old/lib/facter/ldom.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/lib/facter/ldom.rb 1970-01-01 01:00:00.000000000 +0100 @@ -47,15 +47,5 @@ end end end - - # When ldom domainrole control = false, the system is a guest, so we mark it - # as a virtual system: - Facter.add("virtual") do - confine :ldom_domainrole_control => 'false' - has_weight 10 - setcode do - Facter.value(:ldom_domainrole_impl) - end - end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/facter/util/processor.rb new/lib/facter/util/processor.rb --- old/lib/facter/util/processor.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/lib/facter/util/processor.rb 1970-01-01 01:00:00.000000000 +0100 @@ -232,7 +232,7 @@ end end - when "ppc64" + when "ppc64", "ppc64le" File.readlines(cpuinfo).each do |l| if l =~ /processor\s+:\s+(\d+)/ processor_num = $1.to_i diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/facter/version.rb new/lib/facter/version.rb --- old/lib/facter/version.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/lib/facter/version.rb 1970-01-01 01:00:00.000000000 +0100 @@ -1,6 +1,6 @@ module Facter if not defined? FACTERVERSION then - FACTERVERSION = '2.4.3' + FACTERVERSION = '2.4.4' end # Returns the running version of Facter. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/facter/virtual.rb new/lib/facter/virtual.rb --- old/lib/facter/virtual.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/lib/facter/virtual.rb 1970-01-01 01:00:00.000000000 +0100 @@ -90,6 +90,17 @@ end Facter.add("virtual") do + confine :kernel => 'SunOS' + confine :hardwareisa => 'sparc' + confine :ldom_domainrole_control => 'false' + has_weight 20 # Weight this before the default solaris implementation + setcode do + Facter.value(:ldom_domainrole_impl) + end +end + + +Facter.add("virtual") do confine :kernel => 'HP-UX' has_weight 10 setcode do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metadata new/metadata --- old/metadata 1970-01-01 01:00:00.000000000 +0100 +++ new/metadata 1970-01-01 01:00:00.000000000 +0100 @@ -1,7 +1,7 @@ --- !ruby/object:Gem::Specification name: facter version: !ruby/object:Gem::Version - version: 2.4.3 + version: 2.4.4 prerelease: platform: ruby authors: @@ -9,7 +9,7 @@ autorequire: bindir: bin cert_chain: [] -date: 2015-04-02 00:00:00.000000000 Z +date: 2015-05-19 00:00:00.000000000 Z dependencies: [] description: You can prove anything with facts! email: info@puppetlabs.com @@ -190,6 +190,7 @@ - spec/fixtures/cpuinfo/amd64tri - spec/fixtures/cpuinfo/amd64twentyfour-grep - spec/fixtures/cpuinfo/amd64solo +- spec/fixtures/cpuinfo/ppc64le - spec/fixtures/cpuinfo/beaglexm-armel - spec/fixtures/cpuinfo/amd64twentyfour - spec/fixtures/cpuinfo/sparc @@ -537,6 +538,7 @@ - spec/fixtures/cpuinfo/amd64tri - spec/fixtures/cpuinfo/amd64twentyfour-grep - spec/fixtures/cpuinfo/amd64solo +- spec/fixtures/cpuinfo/ppc64le - spec/fixtures/cpuinfo/beaglexm-armel - spec/fixtures/cpuinfo/amd64twentyfour - spec/fixtures/cpuinfo/sparc diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/fixtures/cpuinfo/ppc64le new/spec/fixtures/cpuinfo/ppc64le --- old/spec/fixtures/cpuinfo/ppc64le 1970-01-01 01:00:00.000000000 +0100 +++ new/spec/fixtures/cpuinfo/ppc64le 1970-01-01 01:00:00.000000000 +0100 @@ -0,0 +1,15 @@ +processor : 0 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 1 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +timebase : 512000000 +platform : PowerNV +model : 8247-22L +machine : PowerNV 8247-22L +firmware : OPAL v3 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/unit/application_spec.rb new/spec/unit/application_spec.rb --- old/spec/unit/application_spec.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/spec/unit/application_spec.rb 1970-01-01 01:00:00.000000000 +0100 @@ -54,6 +54,15 @@ end end + ['-h', '--help'].each do |option| + it "issues a deprecation message for `--puppet`" do + Facter::Application.stubs(:exit).with(0) + expect do + Facter::Application.parse([option]) + end.to have_printed('Deprecated: use `puppet facts` instead') + end + end + it 'mutates argv so that non-option arguments are left' do argv = ['-y', '--trace', 'uptime', 'virtual'] Facter::Application.parse(argv) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/unit/dhcp_servers_spec.rb new/spec/unit/dhcp_servers_spec.rb --- old/spec/unit/dhcp_servers_spec.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/spec/unit/dhcp_servers_spec.rb 1970-01-01 01:00:00.000000000 +0100 @@ -175,6 +175,28 @@ Facter.fact(:dhcp_servers).value.should be_nil end end + describe 'with nmcli version >= 0.9.9 available but printing an error to STDERR' do + before :each do + Facter::Core::Execution.stubs(:exec).with('nmcli -t -f STATE g 2>/dev/null').returns("\n") + Facter::Core::Execution.stubs(:exec).with('nmcli --version').returns('nmcli tool, version 0.9.9.0') + end + + it 'should not produce a dhcp_servers fact' do + Facter.fact(:dhcp_servers).value.should be_nil + end + end + + describe 'with nmcli version <= 0.9.8 available but printing an error to STDERR' do + before :each do + Facter::Core::Execution.stubs(:exec).with('nmcli -t -f STATE nm 2>/dev/null').returns("\n") + Facter::Core::Execution.stubs(:exec).with('nmcli --version').returns('nmcli tool, version 0.9.7.0') + end + + it 'should not produce a dhcp_servers fact' do + Facter.fact(:dhcp_servers).value.should be_nil + end + end + end describe "without nmcli available" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/unit/ldom_spec.rb new/spec/unit/ldom_spec.rb --- old/spec/unit/ldom_spec.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/spec/unit/ldom_spec.rb 1970-01-01 01:00:00.000000000 +0100 @@ -57,10 +57,6 @@ it "should return correct serial on version 1.0" do Facter.fact(:ldom_domainchassis).value.should == "0704RB0280" end - - it "should return correct virtual on version 1.0" do - Facter.fact(:virtual).value.should == "LDoms" - end end describe "when running on non ldom hardware" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/unit/processors/os_spec.rb new/spec/unit/processors/os_spec.rb --- old/spec/unit/processors/os_spec.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/spec/unit/processors/os_spec.rb 1970-01-01 01:00:00.000000000 +0100 @@ -40,6 +40,13 @@ expect(count).to eq 2 end + it "should be 2 in ppc64le fixture on Linux" do + Facter.fact(:architecture).stubs(:value).returns("ppc64le") + File.expects(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture_readlines("ppc64le")) + count = subject.get_processor_count + expect(count).to eq 2 + end + it "should be 2 in panda-armel fixture on Linux" do Facter.fact(:architecture).stubs(:value).returns("arm") File.expects(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture_readlines("panda-armel")) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/unit/virtual_spec.rb new/spec/unit/virtual_spec.rb --- old/spec/unit/virtual_spec.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/spec/unit/virtual_spec.rb 1970-01-01 01:00:00.000000000 +0100 @@ -31,6 +31,18 @@ Facter.fact(:virtual).value.should == "zone" end + it "should be LDoms on Solaris when an ldom" do + ldom_fixture = File.read(fixtures('ldom', 'ldom_v1')) + Facter.fact(:kernel).stubs(:value).returns("SunOS") + Facter.fact(:operatingsystem).stubs(:value).returns("Solaris") + Facter.fact(:hardwareisa).stubs(:value).returns("sparc") + Facter::Core::Execution.stubs(:which).with("virtinfo").returns 'virtinfo' + Facter::Core::Execution.stubs(:which).with("vmware").returns nil + Facter::Core::Execution.stubs(:exec).with("virtinfo -ap").returns(ldom_fixture) + Facter.collection.internal_loader.load(:ldom) + Facter.fact(:virtual).value.should == "LDoms" + end + it "should be jail on FreeBSD when a jail in kvm" do Facter.fact(:kernel).stubs(:value).returns("FreeBSD") Facter::Util::Virtual.stubs(:jail?).returns(true)